Skip to content

ci: use the built-in GITHUB_TOKEN instead of FRONTEND_GH_TOKEN - #1140

Merged
jerry-payward merged 3 commits into
masterfrom
jerry/use-builtin-github-token
Nov 10, 2026
Merged

jerry-payward merged 3 commits into
masterfrom
jerry/use-builtin-github-token

Conversation

@jerry-payward

@jerry-payward jerry-payward commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Why

The Canary job on #1139 failed with GitHub token not found because secrets.FRONTEND_GH_TOKEN resolved to an empty string. The secret worked on 2026-10-20 and is no longer in the list of org secrets visible to this repo.

What

  • canary.yml: GH_TOKEN now uses secrets.GITHUB_TOKEN. The Canary job gets pull-requests: write so auto canary can comment on the PR.
  • publish.yml: GITHUB_TOKEN and GH_TOKEN now use secrets.GITHUB_TOKEN. The token: override on both checkouts is removed. The Publish job gets contents: write, pull-requests: write and issues: write so auto shipit can push the release commit and tags and comment on or label released PRs.

Risks to check before merging

  • If master branch protection requires PRs or blocks pushes by github-actions[bot], the release step will fail when it pushes the version bump. The old token likely got around this.
  • Pushes made with the built-in token do not trigger other workflows, so the release commit and tags will not start further runs.
  • Canary on this PR will only show the real result of the new auth once the workflow change is on the PR's merge ref. Publish can only be tested by merging.

After this merges, #1139 needs a rebase or re-run to get a green Canary.

🤖 Generated with Claude Code

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/bitcoin@29.4.1-canary.1140.42878562125.0
# or 
yarn add @magic-ext/bitcoin@29.4.1-canary.1140.42878562125.0

FRONTEND_GH_TOKEN is no longer available to this repo, so Canary fails
with "GitHub token not found". Use the built-in token and grant the
jobs the permissions auto needs.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Comment thread .github/workflows/canary.yml Fixed
Comment thread .github/workflows/publish.yml Fixed
Comment thread .github/workflows/publish.yml Fixed
jerry-payward and others added 2 commits November 10, 2026 10:42
Move GH_TOKEN, NPM_TOKEN and NPM_CONFIG_PROVENANCE out of the
workflow-level env block and onto the auto steps. Install and build
steps no longer see the tokens. Give the Publish build job explicit
read-only permissions.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
auto reads GH_TOKEN or GITHUB_TOKEN for the API, and uses GITHUB_TOKEN
(with the x-access-token prefix) for git pushes in Actions. GH_TOKEN
was redundant.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@jerry-payward
jerry-payward added this pull request to the merge queue Nov 10, 2026
Merged via the queue into master with commit 981647f Nov 10, 2026
11 checks passed
@jerry-payward
jerry-payward deleted the jerry/use-builtin-github-token branch November 10, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants