Repository navigation
chore: Bump gpui-pre to 0.3.9 - #36
Merged
huacnlee merged 1 commit intoOct 13, 2026
Merged
Conversation
Match gpui-kit's 0.3.9 snapshot so downstreams (ai-chat) can move to gpui-pre 0.3.9 and pull the touch release-velocity fling fix from gpui-fast. - Bump gpui-pre / gpui-pre-wgpu pins =0.3.8 → =0.3.9. - Re-vendor gpui-pre-wgpu at 0.3.9, re-applying the `offscreen` headless renderer patch (feature gates + new_headless_with_instance / with_instance / from_headless_context) on top of the 0.3.9 source. - Implement the three platform trait methods gpui-pre 0.3.9 adds, for iOS and Android: PlatformDisplay::refresh_interval (iOS queries UIScreen maximumFramesPerSecond; Android None), Platform::on_displays_changed and PlatformWindow::on_display_changed (no-op on mobile). iOS (aarch64-apple-ios) cargo check passes. Android not built locally (no NDK); the additions are no-ops / None — please confirm in CI.
yuanzhuang-svg
force-pushed
the
feature/yz/gpui-pre-0.3.9-on-main
branch
from
October 13, 2026 07:30
a9fccd7 to
5194a35
Compare
madcodelife
pushed a commit
that referenced
this pull request
Oct 13, 2026
…PlatformWindow (#38) Follow-up to the 0.3.9 bump (#36). gpui-pre 0.3.9 added `PlatformWindow::on_display_changed`; #36 implemented it for `IosWindow` and `AndroidPlatformWindow` but missed `OffscreenPlatformWindow` in `src/offscreen.rs`, which only compiles under the `offscreen` feature. gpui-mobile CI doesn't enable `offscreen`, so it passed; a downstream that turns `offscreen` on (ai-chat's share-as-image) fails to build without it. No-op impl — an offscreen window has no display to change. Verified: `cargo check --target aarch64-apple-ios --features offscreen` passes. Co-authored-by: yuanzhuang-svg <273899003+yuanzhuang-svg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps gpui-pre / gpui-pre-wgpu pins
=0.3.8→=0.3.9to match gpui-kit's 0.3.9 snapshot, so ai-chat can move to gpui-pre 0.3.9 and pull the touch release-velocity fling fix from gpui-fast (longbridge/gpui-fast#65).Based on
main(clean diff; supersedes the earlier #35 which was stacked on the divergentchore/bump-gpui-pre-0.3.8branch).Changes
=0.3.9.gpui-pre-wgpuat 0.3.9, re-applying theoffscreenheadless-renderer patch (feature gates +new_headless_with_instance/with_instance/from_headless_context) on top of the 0.3.9 source. The patch applied cleanly (onlycosmic_text_system.rsdiffers upstream between 0.3.8 and 0.3.9).PlatformDisplay::refresh_interval— iOS queriesUIScreen.maximumFramesPerSecond; Android returnsNone.Platform::on_displays_changed— no-op on mobile (SharedPlatform delegates to AndroidPlatform).PlatformWindow::on_display_changed— no-op on mobile.Test
iOS (
aarch64-apple-ios)cargo checkpasses. Android not built locally (no NDK) — the additions are no-ops /None; please confirm in CI.