Repository navigation
offscreen: implement PlatformWindow::on_display_changed for OffscreenPlatformWindow - #38
Merged
madcodelife merged 1 commit intoOct 13, 2026
Conversation
…PlatformWindow gpui-pre 0.3.9 added PlatformWindow::on_display_changed; the earlier 0.3.9 bump implemented it for IosWindow and AndroidPlatformWindow but missed OffscreenPlatformWindow, which is only compiled under the `offscreen` feature (gpui-mobile's CI doesn't enable it, so it went uncaught; a downstream that turns `offscreen` on — e.g. ai-chat's share-as-image — fails to build without this). No-op: an offscreen window has no display to change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the 0.3.9 bump (#36). gpui-pre 0.3.9 added
PlatformWindow::on_display_changed; #36 implemented it forIosWindowandAndroidPlatformWindowbut missedOffscreenPlatformWindowinsrc/offscreen.rs, which only compiles under theoffscreenfeature. gpui-mobile CI doesn't enableoffscreen, so it passed; a downstream that turnsoffscreenon (ai-chat's share-as-image) fails to build without it.No-op impl — an offscreen window has no display to change.
Verified:
cargo check --target aarch64-apple-ios --features offscreenpasses.