Repository navigation
Fix live Cinnamon accent updates and simplify color selection - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the selected Adwaita-AMOLED theme from blue to another accent left Cinnamon using its old stylesheet because the selected theme name did not change. The installer now calls Cinnamon’s public ReloadTheme API after updating the selected theme, with a manual fallback when no session bus is available.
Guided installation now offers theme accents directly, supports independently selected folder colors (Match theme by default), and adds Change installed colors to refresh existing app themes and icons without selecting components again. The chosen icon mode persists in a small installed marker. Independent icon payloads are checksum-validated before destination changes; recoloring preserves custom GTK4 CSS and personal app settings.
Validation: live non-root Cinnamon 6.0.4 and 6.6.9 sessions passed all eight accents and a return to blue (16 transitions, 126 style assertions, 36 menu/calendar screenshots). All 64 theme/icon combinations pass. Guided setup (27 user cases and 2 administrator cases), 18 shared-system tests, installer/preservation/failure-path/icon/accent/package/manual/Flatpak checks pass. ShellCheck and palette/icon/accent reproducibility checks pass. A reproducible extracted preview archive passes checksum, installation and independent/matching color updates. CI adds the combination checks and live Cinnamon update regression.
No palette values or existing release/tag are changed. Live Wayland sessions and arbitrary third-party Cinnamon applets remain outside this test coverage.