Repository navigation
Add Cinnamon theme-picker previews for every accent - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cinnamon/Mint theme settings fell back to generic thumbnails because the theme supplied no thumbnail.png files. Add compact previews at the actual Cinnamon lookup paths for Desktop, Controls and Window borders. Desktop and Controls illustrations use each selected accent; the neutral window decoration illustration is shared. All PNGs are generated deterministically from the palette using Python’s standard library and shipped prebuilt; the Bash installer gains no dependencies.
Also audit every Cinnamon CSS/SVG against its preset template and reject leftover base-blue accent values. All eight presets already passed: the earlier mixed blue/pink appearance was stale live CSS, addressed by #33, rather than missing palette mappings.
Validation: 15 accent tests, 9 palette tests, 6 packaging tests and 2 manual-installation tests pass. The actual Cinnamon Settings lookup and PictureChooserButton load all three components across all eight accents on Cinnamon 6.0.4 and 6.6.9, saving native chooser screenshots. Rebuilding all overlays on the modern stack changes zero files. The existing modern native Cinnamon fixture also passes (2,421 style nodes, no contrast failures).
CI runs the real chooser check, and native failure annotations retain a shorter diagnostic tail so GitHub’s annotation limit does not truncate the final error. No rendering assertion is weakened and no release/tag is modified.