Skip to content

chore: fix some technical debt around pullback bundle instances #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grunweg merged 3 commits into from
Sep 25, 2026
Merged

chore: fix some technical debt around pullback bundle instances #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd27675
chore: bump to Lean v4.35.0-rc3 and current mathlib
kim-em Sep 25, 2026
870ee32
Merge branch 'master' into bump-toolchain-v4.35.0-rc3
grunweg Sep 25, 2026
4e8f1ec
Tweak comments
grunweg Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions SphereEversion/Global/OneJetBundle.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,6 @@ instance (x : M × M') : Module 𝕜 (FJ¹MM' x) :=

end

set_option backward.isDefEq.respectTransparency false in
set_option backward.isDefEq.respectTransparency.instanceSearchTypes false in
instance : TopologicalSpace J¹MM' := by
delta OneJetSpace OneJetBundle
infer_instance
Expand All @@ -181,6 +179,10 @@ set_option backward.isDefEq.respectTransparency false in
set_option backward.isDefEq.respectTransparency.instanceSearchTypes false in
instance : ChartedSpace HJ J¹MM' := by
delta OneJetSpace OneJetBundle
-- Making `FiberBundle.chartedSpace` apply here means unfolding the `TopologicalSpace J¹MM'`
-- instance above, which unification during instance synthesis will not do.
-- One potential fix is naming the instance:
-- exact FiberBundle.chartedSpace ..
infer_instance

set_option backward.isDefEq.respectTransparency false in
Expand Down
22 changes: 18 additions & 4 deletions SphereEversion/ToMathlib/Geometry/Manifold/VectorBundle/Misc.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,26 @@ end Hom

section Pullback

/-- We need some instances like this to work with negation on pullbacks -/
instance {B B'} {E : B → Type*} {f : B' → B} {x : B'} [∀ x', AddCommGroup (E x')] :
AddCommGroup ((f *ᵖ E) x) := by delta Bundle.Pullback; infer_instance
AddCommGroup ((f *ᵖ E) x) :=
inferInstanceAs <| AddCommGroup (E (f x))

instance {B B'} {E : B → Type*} {f : B' → B} {x : B'} [∀ x', Zero (E x')] : Zero ((f *ᵖ E) x) := by
delta Bundle.Pullback; infer_instance
instance {B B'} {E : B → Type*} {f : B' → B} {x : B'} [∀ x', Zero (E x')] : Zero ((f *ᵖ E) x) :=
inferInstanceAs <| Zero (E (f x))

instance {B B'} {E : B → Type*} {f : B' → B} {x : B'} [∀ x', TopologicalSpace (E x')]
[∀ x', AddCommMonoid (E x')] [∀ x', ContinuousAdd (E x')] : ContinuousAdd ((f *ᵖ E) x) :=
inferInstanceAs <| ContinuousAdd (E (f x))

instance {B B'} {E : B → Type*} {f : B' → B} {x : B'} [∀ x', TopologicalSpace (E x')]
[∀ x', AddCommGroup (E x')] [∀ x', IsTopologicalAddGroup (E x')] :
IsTopologicalAddGroup ((f *ᵖ E) x) :=
inferInstanceAs <| IsTopologicalAddGroup (E (f x))

instance {R B B'} [Semiring R] [TopologicalSpace R] {E : B → Type*} {f : B' → B} {x : B'}
[∀ x', TopologicalSpace (E x')] [∀ x', AddCommMonoid (E x')] [∀ x', Module R (E x')]
[∀ x', ContinuousSMul R (E x')] : ContinuousSMul R ((f *ᵖ E) x) :=
inferInstanceAs <| ContinuousSMul R (E (f x))

variable {B F B' K : Type*} {E : B → Type*} {f : K} [TopologicalSpace B']
[TopologicalSpace (TotalSpace F E)] [TopologicalSpace F] [TopologicalSpace B] [∀ b, Zero (E b)]
Expand Down
2 changes: 1 addition & 1 deletion lean-toolchain
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
leanprover/lean4:v4.35.0-rc3
leanprover/lean4:v4.35.0-rc3
Loading