chore: fix some technical debt around pullback bundle instances - #151
Merged
Merged
Conversation
Mathlib's bundle of continuous linear maps now asks for `IsTopologicalAddGroup` and `ContinuousSMul` on the fibers of the target bundle. Supply those for pullback bundles, and restate the existing pullback instances with `inferInstanceAs` so that they agree with mathlib's `AddCommMonoid ((f *ᵖ E) x)`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Collaborator
|
Thanks! As I had bumps to mathlib queued locally, I merged those first - but I'll glad take the better solution with the tech debt fix. I'll merge master, tweak the comments and merge later today. |
grunweg
changed the title
Collaborator
|
Thanks for the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle.Pullbackis not reducible, these are necessaryinferInstanceAs