Repository navigation
fix(wal): isolate raft-engine entry caches by engine - #398
Merged
Merged
Conversation
50 of 56 tasks
beinan
added a commit
that referenced
this pull request
Oct 20, 2026
## Summary - Add an opt-in `raft-log` storage boundary: one physical engine per node and cloneable raft-rs `Storage` handles for its static session-sharded groups. Persist entries, term ranges and HardState atomically, then wait for a shared physical sync barrier. Bind the layout and node identity before returning any handles. - Reject committed-prefix replacement and term/vote/commit regressions. Look up terms without decoding payloads, and bound each engine range-read request before applying Raft's byte limit. A disk-write error or unwinding sync panic permanently fences every group handle until the physical log is reopened. - Cover real files, independent-engine cache isolation, concurrent sync/error paths, Linux child-process write failures and SIGKILL recovery, and the RawNode persistence/Ready contract. Use the vendored cache correction from #398 and run the optional storage tests in CI. A successful local persist is not a quorum ACK. This increment retains the full log and static membership; transport, snapshots/reclamation, producer deduplication and Lance publication remain follow-up work. It does not switch production ingestion. Refs #378. ## Testing - `cargo test --locked -p lance-context-wal --features raft-log --lib --test raft_log --test raft_log_cache_identity`: 18 passed; the subprocess worker is invoked by its parent tests and ignored as a standalone test. - The three unchanged facade cache tests returned exact wrong payloads on the original engine and passed with the vendored correction. - `cargo clippy --locked -p lance-context-wal --all-features --all-targets -- -D warnings`: passed. - Full `ci-pr-helper` checks passed: workspace Rust tests, Python (229 passed, 2 skipped, 1 expected failure), Ruff, Pyright, formatting and Clippy. Workspace package metadata and spelling checks passed. - The final term-decoding iteration also passes Rust 1.99 Clippy and all 18 durable-storage tests; the truncated-index check and on-disk representation are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engine.rsandpurge.rsdiffer from upstream source; the complete two-file delta is invendor/raft-engine/read-cache-identity.patch, with source revision, archive checksum and licensing provenance alongside it. The WAL crate remains unpublished; publishing it will need a separate dependency packaging decision.Refs #378. This is a prerequisite correctness fix for the ingestion work, not production enablement of the distributed writer.
Testing
cargo test --locked -p lance-context-wal --features lab --test engine_cache: 4 passed. Optional WAL feature Clippy passed.ci-pr-helperchecks passed: workspace Rust tests, Python tests (229 passed, 2 skipped, 1 expected failure), Ruff, Pyright, formatting and Clippy.cargo package --workspace --exclude lance-context-python --allow-dirty --no-verify --all-features --locked; spelling and final source-integrity checks passed.