Repository navigation
feat(wal): add shared durable Raft log storage - #399
Merged
Merged
Conversation
40 of 47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
raft-logstorage boundary: one physical engine per node and cloneable raft-rsStoragehandles for its static session-sharded groups. Persist entries, term ranges and HardState atomically, then wait for a shared physical sync barrier. Bind the layout and node identity before returning any handles.A successful local persist is not a quorum ACK. This increment retains the full log and static membership; transport, snapshots/reclamation, producer deduplication and Lance publication remain follow-up work. It does not switch production ingestion.
Refs #378.
Testing
cargo test --locked -p lance-context-wal --features raft-log --lib --test raft_log --test raft_log_cache_identity: 18 passed; the subprocess worker is invoked by its parent tests and ignored as a standalone test.cargo clippy --locked -p lance-context-wal --all-features --all-targets -- -D warnings: passed.ci-pr-helperchecks passed: workspace Rust tests, Python (229 passed, 2 skipped, 1 expected failure), Ruff, Pyright, formatting and Clippy. Workspace package metadata and spelling checks passed.