Skip to content

fix(master): pay back the claiming-pool gauge when the poller is aborted #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beinan merged 1 commit into from
Oct 8, 2026
Merged

fix(master): pay back the claiming-pool gauge when the poller is aborted #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/lance-context-master/src/scheduler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,7 +1229,10 @@ fn spawn_filtered_pool_poller(
let Some(operation) = state.admission.try_admit() else {
break;
};
// Held across the await so a poller aborted mid-claim (drain,
// shutdown, test teardown) still pays the gauge back.
claiming.increment(1.0);
let claiming_hold = GaugeHold(claiming.clone());
let claim_start = std::time::Instant::now();
let claim = if resident_only {
state
Expand All @@ -1239,7 +1242,7 @@ fn spawn_filtered_pool_poller(
} else {
state.task_store.claim_next_of_kinds(kinds).await
};
claiming.decrement(1.0);
drop(claiming_hold);
match claim {
Ok(Some(claim)) => {
let claim_elapsed = claim_start.elapsed();
Expand Down
Loading