Repository navigation
fix(master): pay back the claiming-pool gauge when the poller is aborted - #360
Merged
Merged
Conversation
lance-format#348 incremented claiming before the etcd claim and decremented after. A poller aborted mid-claim (drain, shutdown, test teardown) skipped the decrement, leaving the gauge elevated. Hold the decrement in the same Drop guard lance-format#353 introduced for the running gauge. Refs lance-format#333. Review round 4, claiming-cancel gap. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
17 of 18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #333. Closes the
claimingcancellation gap noted in review round 4 (credit: production review).The
claiminggauge was incremented before the etcd claim and decremented after. A poller aborted mid-claim (drain, shutdown, test teardown) skipped the decrement. SameGaugeHoldDrop guard as #353, held across the await.Clippy
-D warnings, fmt clean; poller test passes against etcd.🤖 Generated with Claude Code