Skip to content

fix: emit Warning events on node and rule when taint operations fail #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Saloni3494 wants to merge 1 commit into from
Closed

fix: emit Warning events on node and rule when taint operations fail #424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/controller/nodereadinessrule_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,9 @@ func (r *RuleReadinessController) evaluateRuleForNode(ctx context.Context, rule
}
if err != nil {
metrics.Failures.WithLabelValues(rule.Name, string(metrics.FailureReasonRemoveTaintError)).Inc()
msg := fmt.Sprintf("Failed to remove taint '%s:%s': %v", rule.Spec.Taint.Key, rule.Spec.Taint.Effect, err)
r.EventRecorder.Eventf(node, nil, corev1.EventTypeWarning, "RemoveTaintFailed", "RemoveTaint", "Rule %s: %s", rule.Name, msg)
r.EventRecorder.Eventf(rule, nil, corev1.EventTypeWarning, "RemoveTaintFailed", "RemoveTaint", "Node %s: %s", node.Name, msg)
return fmt.Errorf("failed to remove taint: %w", err)
}

Expand Down Expand Up @@ -446,6 +449,9 @@ func (r *RuleReadinessController) evaluateRuleForNode(ctx context.Context, rule
var added bool
if added, err = r.addTaintBySpec(ctx, node, rule); err != nil {
metrics.Failures.WithLabelValues(rule.Name, string(metrics.FailureReasonAddTaintError)).Inc()
msg := fmt.Sprintf("Failed to add taint '%s:%s': %v", rule.Spec.Taint.Key, rule.Spec.Taint.Effect, err)
r.EventRecorder.Eventf(node, nil, corev1.EventTypeWarning, "AddTaintFailed", "AddTaint", "Rule %s: %s", rule.Name, msg)
r.EventRecorder.Eventf(rule, nil, corev1.EventTypeWarning, "AddTaintFailed", "AddTaint", "Node %s: %s", node.Name, msg)
return fmt.Errorf("failed to add taint: %w", err)
}

Expand Down