fix: emit Warning events on node and rule when taint operations fail - #424
fix: emit Warning events on node and rule when taint operations fail#424Saloni3494 wants to merge 1 commit into
Conversation
✅ Deploy Preview for node-readiness-controller canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Saloni3494 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Saloni3494. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Duplicate Of #363 /close not-planned |
What type of PR is this?
What this PR does / why we need it:
This PR resolves an observability gap where the controller failed to emit
Warningevents when node taint operations failed.Previously, if
addTaintBySpecorremoveTaintBySpecfailed (e.g., due to API server RBAC restrictions or patch conflicts), the controller would log an error and incrementmetrics.Failures, but operators had no visibility into these failures throughkubectl describe nodereadinessruleorkubectl describe node.Now, if a taint addition or removal fails, the controller explicitly emits a
Warningevent on both the affectedNodeobject and the managingNodeReadinessRuleobject with the exact underlying error message.Which issue(s) this PR fixes:
Fixes #362
Special notes for your reviewer:
The events use the standard
RemoveTaintFailedandAddTaintFailedreasons so they are easily recognizable inkubectl get events.Does this PR introduce a user-facing change?: