Skip to content

feat: add suspend field to NodeReadinessRuleSpec to pause rule evalua… - #352

Draft
vishnukothakapu wants to merge 1 commit into
kubernetes-sigs:mainfrom
vishnukothakapu:feat/suspend-rule
Draft

feat: add suspend field to NodeReadinessRuleSpec to pause rule evalua…#352
vishnukothakapu wants to merge 1 commit into
kubernetes-sigs:mainfrom
vishnukothakapu:feat/suspend-rule

Conversation

@vishnukothakapu

Copy link
Copy Markdown
Contributor

Description

This PR introduces a suspend boolean field to the NodeReadinessRuleSpec. When a rule is suspended (suspend: true), the controller skips the reconciliation loop for that specific rule, leaving any existing taints and the cluster state exactly as they are. This provides a safe, standard mechanism to pause rule evaluation during maintenance windows or debugging, without needing to delete the rule.

Related Issue

Fixes #335

Type of Change

/kind feature
/kind api-change

Testing

  • Added a unit test in nodereadinessrule_controller_test.go to explicitly verify that when suspend: true is set, the controller skips evaluation and does not append a finalizer.
  • Regenerated CRD manifests and deepcopy functions.

Checklist

  • make test passes
  • make lint passes

Does this PR introduce a user-facing change?

Added `suspend` field to `NodeReadinessRuleSpec`. When `suspend: true` is set, the controller skips evaluation of the rule, effectively pausing taint management while preserving the current cluster state.

@kubernetes-prow kubernetes-prow Bot added kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Aug 4, 2026
@netlify

netlify Bot commented Aug 4, 2026

Copy link
Copy Markdown

Deploy Preview for node-readiness-controller canceled.

Name Link
🔨 Latest commit 4632d31
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/6a724a224169bb00087dbdb2

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vishnukothakapu
Once this PR has been reviewed and has the lgtm label, please assign sergeykanzhelev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2026
@kubernetes-prow

Copy link
Copy Markdown

Hi @vishnukothakapu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2026
@Karthik-K-N

Copy link
Copy Markdown
Contributor

Thanks for the PR, Given its a feature request and API change,I would recommend its always better to get consciousness about the proposed feature on the parent issue before proceeding with the PR, it generally saves duplicate work or time.

@vishnukothakapu

Copy link
Copy Markdown
Contributor Author

Contributor

Thanks for the tip, @Karthik-K-N! You're right. I had some free time, so I thought I'd quickly prototype it to get a feel for how it would look. Going forward, I'll wait for consensus on the parent issue before spending time on implementation, so I don't end up working on something that might not be needed.

Once the parent issue is reviewed, I'd really appreciate any feedback on the implementation as well. Thanks!

@Karthik-K-N

Copy link
Copy Markdown
Contributor

Contributor

Thanks for the tip, @Karthik-K-N! You're right. I had some free time, so I thought I'd quickly prototype it to get a feel for how it would look. Going forward, I'll wait for consensus on the parent issue before spending time on implementation, so I don't end up working on something that might not be needed.

Once the parent issue is reviewed, I'd really appreciate any feedback on the implementation as well. Thanks!

That is completely fair. Apologies for that, I thought the PR is ready for review, May be if you think its under experiment, feel free to mark it as Draft or WIP.

@vishnukothakapu
vishnukothakapu marked this pull request as draft August 5, 2026 13:00
@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a suspend field to NodeReadinessRuleSpec to pause rule evaluation

2 participants