feat: add suspend field to NodeReadinessRuleSpec to pause rule evalua… - #352
feat: add suspend field to NodeReadinessRuleSpec to pause rule evalua…#352vishnukothakapu wants to merge 1 commit into
Conversation
✅ Deploy Preview for node-readiness-controller canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vishnukothakapu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @vishnukothakapu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thanks for the PR, Given its a feature request and API change,I would recommend its always better to get consciousness about the proposed feature on the parent issue before proceeding with the PR, it generally saves duplicate work or time. |
Thanks for the tip, @Karthik-K-N! You're right. I had some free time, so I thought I'd quickly prototype it to get a feel for how it would look. Going forward, I'll wait for consensus on the parent issue before spending time on implementation, so I don't end up working on something that might not be needed. Once the parent issue is reviewed, I'd really appreciate any feedback on the implementation as well. Thanks! |
That is completely fair. Apologies for that, I thought the PR is ready for review, May be if you think its under experiment, feel free to mark it as Draft or WIP. |
Description
This PR introduces a
suspendboolean field to theNodeReadinessRuleSpec. When a rule is suspended (suspend: true), the controller skips the reconciliation loop for that specific rule, leaving any existing taints and the cluster state exactly as they are. This provides a safe, standard mechanism to pause rule evaluation during maintenance windows or debugging, without needing to delete the rule.Related Issue
Fixes #335
Type of Change
/kind feature
/kind api-change
Testing
nodereadinessrule_controller_test.goto explicitly verify that whensuspend: trueis set, the controller skips evaluation and does not append a finalizer.Checklist
make testpassesmake lintpassesDoes this PR introduce a user-facing change?