feat: add suspend field to NodeReadinessRuleSpec - #423
Conversation
✅ Deploy Preview for node-readiness-controller canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Saloni3494 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Saloni3494. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Duplicate Of #352 /close not-planned |
What type of PR is this?
What this PR does / why we need it:
This PR adds a
suspendboolean field to theNodeReadinessRuleSpec.Currently, there is no way to temporarily disable or pause the evaluation of a
NodeReadinessRule. If an administrator needs to perform maintenance on a cluster, test a change, or debug an issue without the controller constantly evaluating and applying/removing taints, their only option is to delete the rule entirely (which un-taints all nodes) or switch it to dry-run mode (which still consumes controller cycles to compute node evaluations).By setting
suspend: true, the controllers will simply skip the reconciliation loop for that rule, making no changes to the cluster or the rule's status. The rule essentially becomes frozen in its current state.Which issue(s) this PR fixes:
Fixes #335
Special notes for your reviewer:
rule.Spec.Suspendwas added at the top of theRuleReconcilerand within theNodeReconcilerrule loop.Does this PR introduce a user-facing change?: