Skip to content

feat: add suspend field to NodeReadinessRuleSpec - #423

Closed
Saloni3494 wants to merge 1 commit into
kubernetes-sigs:mainfrom
Saloni3494:issue-335
Closed

feat: add suspend field to NodeReadinessRuleSpec#423
Saloni3494 wants to merge 1 commit into
kubernetes-sigs:mainfrom
Saloni3494:issue-335

Conversation

@Saloni3494

Copy link
Copy Markdown

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds a suspend boolean field to the NodeReadinessRuleSpec.

Currently, there is no way to temporarily disable or pause the evaluation of a NodeReadinessRule. If an administrator needs to perform maintenance on a cluster, test a change, or debug an issue without the controller constantly evaluating and applying/removing taints, their only option is to delete the rule entirely (which un-taints all nodes) or switch it to dry-run mode (which still consumes controller cycles to compute node evaluations).

By setting suspend: true, the controllers will simply skip the reconciliation loop for that rule, making no changes to the cluster or the rule's status. The rule essentially becomes frozen in its current state.

Which issue(s) this PR fixes:
Fixes #335

Special notes for your reviewer:

  • A check for rule.Spec.Suspend was added at the top of the RuleReconciler and within the NodeReconciler rule loop.
  • The CRDs were regenerated and a new E2E test was added to verify that a suspended rule does not take action on unsatisfied node conditions.

Does this PR introduce a user-facing change?:

Added a `suspend` field to `NodeReadinessRuleSpec`. When set to true, the controller will temporarily bypass all evaluations and taint modifications for the rule, freezing its current cluster state.

@netlify

netlify Bot commented Aug 18, 2026

Copy link
Copy Markdown

Deploy Preview for node-readiness-controller canceled.

Name Link
🔨 Latest commit 8a691c7
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/6a83ce1fee94fd0008824224

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Saloni3494
Once this PR has been reviewed and has the lgtm label, please assign ajaysundark for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow

Copy link
Copy Markdown

Hi @Saloni3494. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2026
@ajaysundark

Copy link
Copy Markdown
Contributor

Duplicate Of #352

/close not-planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a suspend field to NodeReadinessRuleSpec to pause rule evaluation

2 participants