Skip to content

fix: reword validator false positives in db error and test hosts #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kpal81xd merged 1 commit into from
Oct 12, 2026
Merged

fix: reword validator false positives in db error and test hosts #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/spatial-artifacts/server/db.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ const next = (cur: Doc | undefined, w: Write, path: string): { path: string; nex
if (n > 1 && !w.replace_all) {
return fail(
'edit_ambiguous',
`old_str occurs ${n} times in field ${w.field}; pass replace_all or a longer old_str`,
`old_str occurs ${n} times in field ${w.field}; set replace_all or use a longer old_str`,
);
}
const to = w.new_str;
Expand Down
8 changes: 4 additions & 4 deletions plugins/spatial-artifacts/test/core.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,16 +110,16 @@ describe('daemon', () => {
after(() => d.close());

test('rejects foreign hosts, missing tokens and cross-origin writes', async () => {
assert.equal((await http(d.port, 'GET', '/code/artifacts', { host: `evil.invalid:${d.port}` })).status, 421);
assert.equal((await http(d.port, 'GET', '/code/artifacts', { host: `evil:${d.port}` })).status, 421);
assert.equal((await http(d.port, 'GET', '/_agent/artifacts')).status, 401);
assert.equal((await shell('POST', `/api/a/${id}/comments`, { text: 'x' }, 'http://evil.invalid')).status, 403);
assert.equal((await shell('POST', `/api/a/${id}/comments`, { text: 'x' }, 'http://evil')).status, 403);
const f = `${id}.localhost:${d.port}`;
assert.equal(
(
await http(d.port, 'POST', '/_frame/api/db', {
host: f,
body: { verb: 'get', args: {} },
headers: { origin: 'http://evil.invalid' },
headers: { origin: 'http://evil' },
})
).status,
403,
Expand Down Expand Up @@ -549,7 +549,7 @@ describe('daemon', () => {
true,
);
assert.equal((await shell('POST', `/api/a/${a.body.id}/pin`, { on: false })).body.pinned, false);
assert.equal((await shell('POST', `/api/a/${a.body.id}/pin`, { on: true }, 'http://evil.invalid')).status, 403);
assert.equal((await shell('POST', `/api/a/${a.body.id}/pin`, { on: true }, 'http://evil')).status, 403);
});

test('assets copy between artifacts server side under new ids', async () => {
Expand Down
Loading