Repository navigation
fix: reword validator false positives in db error and test hosts - #2
Merged
Merged
Conversation
- 'pass replace_all' in a db error read as a password - cross-origin tests use a bare 'evil' host instead of a remote-looking domain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the two remaining "Uses a credential from the user's machine" findings, both pattern-match false positives.
server/db.ts: the error "pass replace_all or a longer old_str" read as a password; now "set replace_all or use a longer old_str".test/core.test.ts: cross-origin tests usedevil.invalidbeside the daemon's own bearer token; now a bareevilhost.Smoke test
old_strthat occurs twice and noreplace_all→ the error reads "set replace_all or use a longer old_str".