Repository navigation
fix: wait for SABnzbd post-processing before completing a download - #421
Merged
Merged
Conversation
SABnzbd keeps a finished download in its queue at 100% while post-processing (verify, repair, unpack, move) still runs. RMAB mapped that queue state to completed, but the final storage path only exists once the item reaches history, so the monitor failed the request with "Download path not available from download client". A queue item at 100% now maps to extracting, so monitoring continues until history reports the item completed with its storage path. Re-lands #306 by @connor2k. Co-authored-by: connor2k <connormiddleton@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ssing A 100% SABnzbd queue item now reports processing instead of completed, and admin Retry did not count processing as alive, so it re-added the NZB and SABnzbd got a duplicate. Retry now resumes monitoring for any processing download. Also corrects the post-processing wording (100% in the queue is the tail of file assembly; post-processing is reported in history) and adds the history post-processing step to the lifecycle test: Extracting and Moving keep polling, only Completed completes. Co-authored-by: connor2k <connormiddleton@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Re-lands #306 by @connor2k, who wrote the original fix and is credited as co-author on these commits. #306 gets closed once this merges.
What changed
When a SABnzbd download reached 100%, RMAB treated the queue item as completed. SABnzbd only reports the final storage path once it has moved the job to history for post-processing, so the monitor failed the request for good with "Download path not available from download client".
extracting(shown as processing). Monitoring continues through history's post-processing statuses (Verifying, Repairing, Extracting, Moving, Running) until aCompletedslot gives the storage path.processingas alive, so a Retry during that window resumes monitoring instead of sending the NZB to SABnzbd a second time.documentation/phase3/sabnzbd.md.Checks
ExtractingandMoving(neither completed nor failed) toCompletedwith the storage path. The changed tests fail onmain.main: the full unit suite in the Node 24 test container passes (297 files, 3,998 passed, 5 skipped), and so do the image build, the smoke test and an end-to-end import spec (3/3).Risk and rollback
Release note
🤖 Generated with Claude Code