Repository navigation
Conversation
Owner
|
Thanks @ColeTown. I checked this against qBittorrent 5.2's change and it holds up, including the strict receipt checks. Landing it as is, with you as co-author. Leaving this open until it lands. |
This was referenced Oct 20, 2026
kikootwo
added a commit
that referenced
this pull request
Oct 20, 2026
Re-land of #295. qBittorrent 5.2 answers /api/v2/torrents/add with a JSON receipt instead of Ok.; both upload paths now accept Ok. or a receipt confirming exactly the submitted hash (one success, no failures, nothing pending). Rejected receipts are logged with their content. Documents the hybrid/base32 hash limit as a follow-up. Co-authored-by: Cole Townsend <33290898+ColeTown@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
@ColeTown this landed in #420 with you as co-author, and it'll be in the next release. Thanks again! Two small additions on top: a rejected receipt is now logged with its content, so a hash mismatch shows the ID qBittorrent returned, and the docs note the hybrid/base32 hash limit, which is tracked in #422. |
Merged
Owner
|
@ColeTown this is out in v1.2.10: https://github.com/kikootwo/ReadMeABook/releases/tag/v1.2.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qBittorrent 5.2 returns a JSON receipt after adding a torrent (upstream change). RMAB currently requires
Ok., so it reports a failure even when the client accepted the download.Accept both formats for magnets and
.torrentuploads. JSON receipts must confirm exactly the submitted hash, with one success and no failures or pending additions. Existing duplicate handling stays unchanged.Validation covers both upload paths over local HTTP with real Axios and torrent parsing: legacy/JSON success, malformed or mismatched receipts, pending additions, HTTP errors and existing downloads. The JSON success cases reproduce the bug against unchanged
main. Full test suite, TypeScript, Next.js production build and isolated Docker image build pass.Developed with AI assistance using OpenAI Codex (GPT-6 Astra), with human review.