Skip to content

test(ethereum): require advanced mode for MakerDAO calldata #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pastaghost merged 3 commits into from
Aug 27, 2026
+9 −2
Merged

test(ethereum): require advanced mode for MakerDAO calldata #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92e8745
test(ethereum): require advanced mode for MakerDAO calldata
BitHighlander Aug 27, 2026
8df52c2
Merge branch 'master' into fix/7142-makerdao-advanced-mode-tests
BitHighlander Aug 27, 2026
7c04903
test(solana): match AdvancedMode refusal
BitHighlander Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/test_msg_ethereum_makerdao.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ class TestMsgEthereumtxMakerDAO(common.KeepKeyTest):
def test_generate(self):
self.requires_fullFeature()
self.setup_mnemonic_nopin_nopassphrase()
# MakerDAO calldata now follows the generic blind-signing path.
self.client.apply_policy("AdvancedMode", 1)

sig_v, sig_r, sig_s = self.client.ethereum_sign_tx(
n=[2147483692,2147483708,2147483648,0,0],
Expand All @@ -50,6 +52,8 @@ def test_generate(self):
def test_deposit(self):
self.requires_fullFeature()
self.setup_mnemonic_nopin_nopassphrase()
# MakerDAO calldata now follows the generic blind-signing path.
self.client.apply_policy("AdvancedMode", 1)

sig_v, sig_r, sig_s = self.client.ethereum_sign_tx(
n=[2147483692,2147483708,2147483648,0,0],
Expand All @@ -71,6 +75,8 @@ def test_deposit(self):
def test_close(self):
self.requires_fullFeature()
self.setup_mnemonic_nopin_nopassphrase()
# MakerDAO calldata now follows the generic blind-signing path.
self.client.apply_policy("AdvancedMode", 1)

sig_v, sig_r, sig_s = self.client.ethereum_sign_tx(
n=[2147483692,2147483708,2147483648,0,0],
Expand All @@ -92,6 +98,8 @@ def test_close(self):
def test_free(self):
self.requires_fullFeature()
self.setup_mnemonic_nopin_nopassphrase()
# MakerDAO calldata now follows the generic blind-signing path.
self.client.apply_policy("AdvancedMode", 1)

sig_v, sig_r, sig_s = self.client.ethereum_sign_tx(
n=[2147483692,2147483708,2147483648,0,0],
Expand All @@ -111,4 +119,3 @@ def test_free(self):

if __name__ == '__main__':
unittest.main()

2 changes: 1 addition & 1 deletion tests/test_msg_solana_signtx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ def test_solana_sign_token_transfer(self):
with pytest.raises(CallException) as exc:
self.client.call(messages.SolanaSignTx(
address_n=parse_path("m/44'/501'/0'/0'"), raw_tx=raw_tx))
self.assertIn("policy", str(exc.value))
self.assertIn("AdvancedMode", str(exc.value))
Comment thread
BitHighlander marked this conversation as resolved.

def test_solana_sign_token_approve(self):
"""Unchecked SPL Approve is opaque because no mint is signed."""
Expand Down
Loading