test(ethereum): require advanced mode for MakerDAO calldata - #221
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates integration tests to align with firmware behavior that now gates opaque/calldata signing behind the AdvancedMode policy, ensuring MakerDAO calldata vectors opt in to blind-signing while keeping deterministic signature assertions.
Changes:
- Enable
AdvancedModein the four legacy MakerDAO Ethereum signing vectors to use the generic blind-signing (full-calldata) path. - Update a Solana opaque signing test to check for an
AdvancedMode-related policy failure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_msg_solana_signtx.py | Adjusts the expected failure substring for a policy-gated opaque Solana token transfer signing attempt. |
| tests/test_msg_ethereum_makerdao.py | Opts MakerDAO calldata signing tests into AdvancedMode to match new blind-signing requirements while preserving deterministic signature checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
pastaghost
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
keepkey-firmware PR #473 deliberately removes legacy MakerDAO semantic clear-signing. The old integration tests attempted contract-data signing without the required blind-signing opt-in, causing the firmware release PR integration job to fail closed as intended.
Validation
This PR targets the active 7.14.2 companion-test branch so the firmware release child PR can pin the combined test head without changing unrelated default-branch behavior.