Repository navigation
fix: drop audit from the standalone starter's release gate - #513
Merged
Merged
Conversation
The bare starter (#503, "simplify init to one bare starter") scaffolds with zero example routes by design. urlcode audit refuses "ready" for any project with no active routes regardless of --expect-routes, so npm run audit can never pass for it. This made the "pin starter to new core version" step of every release fail after a successful npm publish (observed pinning 0.5.8: #512). validate and test still gate the pin; audit still works fine run standalone. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
4 tasks done
jimhoyd
added a commit
that referenced
this pull request
Sep 23, 2026
…516) Same conflict as audit (#513): the bare starter (#503) ships with zero example routes by design, and urlcode benchmark refuses outright ("No GET/HEAD workload: add representative successful request fixtures") with nothing to request. Observed running the 0.5.8 template-pin step right after #513 merged. benchmark still works standalone once routes are added. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
urlcode auditrefuses "ready" status for any project with zero active routes (notReadyReasons: ["no-active-routes"]), regardless of whether--expect-routesmatches. There's no override flag for this.scripts/release-template.ts'supdateTemplate()runsvalidate,testandauditas release-blocking checks before opening the starter-pin PR. Since the starter is now intentionally routeless,auditcan never pass there, so the "pin starter to new core version" step now fails on every release — observed pinning0.5.8(see #512).Change
Drop
auditfrom the release-gate script list (keepvalidateandtest).npm run auditin the starter/template still works fine standalone — it's just no longer a blocking gate for a starter that's deliberately empty. Updated the matching prose indocs/DEVELOPMENT-PIPELINE.mdand the release-PR body text it writes.Paired with urlcode-template#23, which fixes that repo's own stale
--expect-routes 2(now0) sonpm run auditstill reports the correct count when run manually.Verification
npm run typechecknode --test test/release-template.test.tsnode scripts/check-local-links.ts