Repository navigation
fix: also drop benchmark from the standalone starter's release gate - #516
Merged
Merged
Conversation
Same conflict as audit (#513): the bare starter (#503) ships with zero example routes by design, and urlcode benchmark refuses outright ("No GET/HEAD workload: add representative successful request fixtures") with nothing to request. Observed running the 0.5.8 template-pin step right after #513 merged. benchmark still works standalone once routes are added. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #513. Running the actual
0.5.8template-pin step (npm run release:template -- --version 0.5.8 --execute) after #513 merged hit the same conflict one step further down:urlcode benchmarkrefuses outright against the bare starter (#503, zero example routes by design):Change
Drop
benchmarkfromupdateTemplate()'s release-gate scripts alongsideaudit(already removed in #513), keeping onlyvalidateandtest.npm run benchmarkstill works standalone once routes exist. Updated the matchingdocs/DEVELOPMENT-PIPELINE.mdprose and PR body text.Verification
npm run typechecknode --test test/release-template.test.tsnode scripts/check-local-links.tsnpm run release:template -- --version 0.5.8 --executelocally with this fix applied — it now gets past validate/test cleanly (see follow-up: it will open the actual starter-pin PR against urlcode-template)