root - chore: raise Node engine floor to >=22.19 - #98
Merged
Conversation
Align engines.node with the toolchain after the docula 2.1.0 upgrade (#97). docula 2.1.0 (and its transitive undici) require Node ^22.19.0 || >=24; .nvmrc (24) and CI (node 22/24/26, where 22.x is >=22.19) already satisfy this. - engines.node: >=22 -> >=22.19.0 pnpm build and pnpm test:ci pass (612 tests, 100% statement/line coverage). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XqhnMb2Khr8eYnWmYbAmtd
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 1399 1399
Branches 308 303 -5
=========================================
Hits 1399 1399 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the declared Node engine floor with the toolchain after the
docula2.1.0 upgrade (#97), as flagged by the Codex reviewer.Change
engines.node>=22→>=22.19.0docula@2.1.0(and its transitiveundici) declarenode: "^22.19.0 || >=24"..nvmrc(24) and CI (Node 22/24/26, where 22.x resolves to ≥22.19) already satisfy this — this change just makes the declared range consistent with what the toolchain actually needs.Tests
pnpm test:cipasses (612 tests, 100% statement/line coverage)pnpm buildpasses🤖 Generated with Claude Code
https://claude.ai/code/session_01XqhnMb2Khr8eYnWmYbAmtd
Generated by Claude Code