root - chore: upgrade hashery (breaking) - #100
Merged
Merged
Conversation
- hashery ^2.0.0 → ^3.0.0 hashery 3.0.0 is a toolchain-only major (pnpm 11, build/CI); its public API is unchanged (Hashery still extends Hookified; new Hashery(), instanceof, and toHashSync() behave identically). The only breaking aspect is a raised minimum Node of 22.18, already satisfied by engines.node >=22.19.0. No source changes required; the large-key tests confirm the djb2 digest output is unchanged. pnpm build and pnpm test:ci pass (612 tests, 100% statement/line coverage). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XqhnMb2Khr8eYnWmYbAmtd
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the hashery dependency from version ^2.0.0 to ^3.0.0 in package.json and updates the lockfile (pnpm-lock.yaml) to reflect this change, which also cleans up the unused hookified@3.0.0 package. There are no review comments, and I have no feedback to provide.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 1399 1399
Branches 308 308
=========================================
Hits 1399 1399 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade the
hasheryruntime dependency (major).Versions
hashery2.0.0→3.0.0Tests
pnpm test:cipasses (612 tests, 100% statement/line coverage)pnpm buildpassesBreaking notes
hashery3.0.0 is a toolchain-only major (pnpm 11, build/CI modernization) — its public API is unchanged:Hasherystill extendsHookified, andnew Hashery(),instanceof Hashery, andtoHashSync()behave identically. The only breaking aspect is a raised minimum Node of 22.18, already satisfied byengines.node >=22.19.0(#98). No source changes were required, and the large-key tests confirm the djb2 digest output is byte-identical (no cache-key drift).🤖 Generated with Claude Code
https://claude.ai/code/session_01XqhnMb2Khr8eYnWmYbAmtd
Generated by Claude Code