Repository navigation
Conversation
The calibration bar was display-only, so joints could only be moved with the nudge buttons. It is now a range input that moves the servo on release and is disabled while a move is in flight. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This reverts commit 2296c37.
The generic form-group range margin outranked the class selector and pushed the slider below the drawn track. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe setup calibration guide now uses an interactive range input. Slider movement updates the displayed angle, and releasing the slider requests servo movement through shared calibration logic. ChangesServo calibration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk was identified in the calibration slider changes; proceed with normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| <div class="servo-slider-track"> | ||
| <div class="servo-slider-bg"><div id="servo-safe-band" class="servo-safe-band"></div></div> | ||
| <input type="range" id="servo-slider" min="0" max="180" value="90"> | ||
| <input type="range" id="servo-slider" class="servo-slider" min="0" max="180" value="90"> |
There was a problem hiding this comment.
I intentionally kept the slider in the setup wizard display-only for safety reasons.
During calibration, "/setup/servo" can move through the full 0–180° range without the normal safe-range clamp. Making the slider interactive makes it too easy to accidentally command a large movement, especially on mobile where precise slider control is difficult. That can cause parts to collide or cables to be pulled.
The step buttons are deliberate: they force the user to explore the range gradually and keep each movement small and predictable.
Please keep the setup wizard slider visual-only and retain the nudge buttons as the only way to move the servo during calibration. Improving the visual slider styling/synchronization is fine, but I don't want direct dragging to command servo movement here.
What
.servo-sliderstyle, with a selector specific enough that the generic.form-group input[type=range]margin no longer pushes the thumb below the track.Checks
type(scope): summarytype!:plus aBREAKING CHANGE:footer — none; UI only, no API changepio runand/orpio test -e nativewhen that code changed —pio run; no settings validation touchednpm test --prefix packages/tiny-engineer-cursor/…/tiny-engineer-antigravity/…/tiny-engineer-claude-codewhen that package changed — N/A, no package changessrc/http/index_page.cpp) +docs/api.md(and README /docs/hardware/testing.mdif the route list changed) — no route or parameter changes;/setup/servois called as beforedocs/settings.md; no rawaccess_tokenin logs — N/A.f3d+ exported.3mf; CERN-OHL-S;AiEmblem.3mfnot used as a branding swap — N/Ainclude/pins.h+docs/hardware/together — N/A.env, tokens, or Wi-Fi passwords in logs or screenshotsPCB (if this PR changes a board)
N/A — no board changes.
Summary by CodeRabbit