Repository navigation
fix: use native shortcut modifiers and labels - #11
Merged
Merged
Conversation
Use Command on macOS and Control elsewhere for application shortcuts. Render native shortcut names in menus, tooltips, settings, and keycaps, and use the same modifier for selection copying and the image viewer. Keep Mac control-key editing aliases on macOS so they do not shadow application shortcuts on Linux and Windows. Add native word navigation and regression coverage, and document the platform conventions. Co-Authored-By: GPT-6 <noreply@openai.com>
itz4blitz
approved these changes
Oct 17, 2026
itz4blitz
left a comment
itz4blitz
left a comment
Owner
There was a problem hiding this comment.
Native primary-modifier shortcuts look correct: Command on macOS, Ctrl on Linux and Windows, with the Mac control-key editing aliases kept from stealing Ctrl+K. macOS, Linux, and Windows CI are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux the interface showed Mac shortcut glyphs such as ⌘K, and the bindings required Super instead of Ctrl. Use GPUI's native primary modifier: Command on macOS, Ctrl on Linux and Windows. “Jump to…” now shows and uses Ctrl+K on Linux.
Update application bindings, shortcut labels in keycaps/menus/tooltips/settings, accessibility labels, selected-message copying, and image viewer controls. Keep Mac control-key editing aliases on macOS so they cannot steal Ctrl+K or other app shortcuts while typing elsewhere. Add native word and document navigation in text fields and document the platform conventions in README.
Based directly on current upstream
main(4b1c4d5), independently of #8 and #10.Validation:
git diff --checkpasses. macOS/Windows runtime behavior has not been tested locally.