Repository navigation
fix: keep sidebar previews within their row - #13
Merged
Merged
Conversation
Collapse embedded line breaks and tabs for sidebar display so multiline messages and drafts cannot paint over neighboring Inbox rows. Clip the title and preview slots and size them with the text step. Preserve full message and draft formatting outside the sidebar. Cover multiline preview and draft inputs with a regression test and update the Inbox design specification. All 40 sidebar tests pass. Co-Authored-By: GPT-6 <noreply@openai.com>
itz4blitz
approved these changes
Oct 17, 2026
itz4blitz
left a comment
itz4blitz
left a comment
Owner
There was a problem hiding this comment.
Flattening sidebar previews to one display line fixes the row overflow without changing stored drafts or full messages. macOS, Linux, and Windows CI are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiline message previews in the Inbox painted over conversation titles and neighboring rows. The preview slot reserved one line, but GPUI still honored embedded newlines despite the text's nowrap/truncation style. Resizing the sidebar moved the overlapping text.
Flatten sidebar previews, drafts, names, and typing/activity/status text to a single display line, including Inbox app rows. Clip title and preview slots, prevent vertical shrinking, and size the slots with the text-size setting. Full messages and stored drafts keep their formatting. Update the Inbox design specification with the display constraint.
This is based directly on current upstream
main, independently of #10 and #11.Validation:
git diff --checkpasses. The reported screenshot shows the original overflow; interactive GUI behavior after the fix has not been visually verified.