-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[Backport release/3.0.0] Cache pip and uv downloads in GitHub Actions #7321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mataylor-nvidia
merged 1 commit into
isaac-sim:release/3.0.0
from
mataylor-nvidia:mataylor/ci-cache-pip-uv-release-3.0.0
Aug 24, 2026
+49
−3
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # No changelog entry / version bump: CI-only change. Enables the pip cache in | ||
| # actions/setup-python and the uv cache in astral-sh/setup-uv across the | ||
| # workflows that install Python packages, so an index outage no longer fails a | ||
| # job once with-python-package-retries.sh exhausts its retries. No source | ||
| # package or published wheel is affected. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the upstream
v6tag is moved, this newly added step executes unreviewed third-party code in the wheel job, allowing workflow data, generated artifacts, or cache entries to be compromised. Pinastral-sh/setup-uvto a reviewed full commit SHA, consistent with the other pinned actions in this job.How this was verified: Every enabled wheel build resolves the mutable
astral-sh/setup-uv@v6reference before building and testing the artifact.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently there is no pinned version of setup-uv used in the rest of the pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right — the existing
astral-sh/setup-uv@v6references elsewhere in the pipeline (e.g.docs.yaml,kitless-docker.yml,.github/actions/install-ci-run) are all unpinned, and this PR is a faithful backport of #7287. Flagging this here is inconsistent with the established convention in the repo.That said, using mutable major-version tags for third-party actions is a real supply-chain risk for a workflow that builds and signs release artifacts. If it's something worth addressing, it would be better done as a repo-wide follow-up on
develop(pinning allsetup-uvand other third-party action references to SHAs) rather than blocking this backport.Fair point — withdrawing the concern for this PR.
Shall I remember this as a rule: "Do not flag unpinned third-party action tags (
@v6, etc.) unless the repo already pins them to commit SHAs — flag it only as a repo-wide issue, not per-file"?