Fix cmake version for uv build from source packages on aarch64 - #7290
Fix cmake version for uv build from source packages on aarch64#7290peterd-NV wants to merge 3 commits into
Conversation
Greptile SummaryThis PR configures uv to pass CMake’s compatibility-policy floor specifically when building the source-only
Confidence Score: 5/5The PR appears safe to merge, with no concrete regressions or blocking failures identified. The build variable is scoped to the exact source-only dependency that requires CMake compatibility handling, and its reachable Linux build paths do not reveal a conflicting platform contract. Important Files Changed
Reviews (1): Last reviewed commit: "fix cmake version for uv build from sour..." | Re-trigger Greptile |
There was a problem hiding this comment.
Isaac Lab Review Bot
Adds a package-scoped uv build variable for egl-probe, setting CMAKE_POLICY_VERSION_MINIMUM=3.5 to support CMake 4 when resolving the mimic extra. The change includes a focused configuration test and changelog fragment.
- Design and architecture: The compatibility override is scoped to the
egl-probebuild rather than applied globally, preserving unrelated package builds and existing uv resolution, index, and dependency override behavior. - API: No public Python APIs, CLI arguments, extras, or dependency defaults are changed. The additive
[tool.uv]configuration affects only the build environment for the normalizedegl-probepackage name. - Implementation: The TOML entry is placed correctly in the existing
[tool.uv]table, and the regression test verifies the exact package-specific variable mapping. The test validates repository configuration rather than executing an actual CMake 4 source build, leaving that end-to-end path dependent on CI or platform validation.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Description
Fixes
uv run --extra mimicfailing during dependency resolution on Linux aarch64 systems using CMake 4.This is a follow-up to #6717 that added
CMAKE_POLICY_VERSION_MINIMUM=3.5handling around ARM dependency builds performed by the Isaac Lab installer.This PR extends the same compatibility policy to uv's package-specific build environment.
Fixes # (issue)
Fixes failing build for Isaac Lab Mimic when running uv.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there