Make XR experiences show all scene partitions - #7271
Draft
hougantc-nvda wants to merge 1 commit into
Draft
Conversation
Set the spectator policy in both OpenXR app configs. This makes direct launches match AppLauncher XR behavior. Add a static contract assertion for both experiences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Default-on per-environment Isaac RTX scene partitioning requires an unpartitioned spectator view for XR. This PR sets:
rtx.scenePartitioning.showAllPartitionsByDefault = truein exactly the two standard OpenXR experiences, before RTX startup:
apps/isaaclab.python.xr.openxr.kitapps/isaaclab.python.xr.openxr.headless.kitIt also adds a focused static contract test for both experience files and a changelog fragment. No dependencies are added.
Baseline interpretation
Current
developalready injects--/rtx/scenePartitioning/showAllPartitionsByDefault=truefromAppLauncherwhenever XR is requested (merged in #7053). Therefore the normaluv run --extra teleop ... --xrpath is expected to be configured correctly before this PR.This change does not claim to introduce the Isaac Sim 6.1 renderer fix or to make an already-failing
AppLauncherpath pass. It makes the shipped XR experience files self-contained and safe when launched directly or through a path that does not useAppLauncher.Type of change
Validation
Controlled static before/after
2 failed, 6 passed; both XR cases failed because the setting was absent.8 passed.AppLauncherXR argument coverage:23 passed.pre-commit run --all-files: all hooks passed, including TOML, RST, changelog, spelling, formatting, and Git LFS pointer checks.397685bada014f4911a4f3f05b80d4e464cb0b7c.Isaac Sim / Kit target and runtime limitation
The
developCI pin is:6.1.0-alpha.50(b86cf6ce)110.3.0-360924sha256:e7cd73cd7a9a6621274bd3a1bacddfd4ac1a15f92893e6a10cfb6b8100762a0cThe exact image is on Isaac Lab's internal NGC mirror. The local Horde account was denied access to that manifest, and the only locally installed Kit oracle is Isaac Sim
6.0.1.0, which does not contain/rtx/scenePartitioning/showAllPartitionsByDefault. I did not substitute 6.0.1 for the required 6.1 validation.Consequently, this draft does not claim that the requested runtime command was exercised on 6.1, nor that the steering wheel, bin/environment geometry, or robot PiP were visually verified in IWER. The upstream PR workflow is configured to build and test against the exact pinned 6.1 image; visual IWER validation remains outstanding.
Screenshots
Not available because the exact 6.1 XR/IWER runtime could not be launched from the local Horde account.
Checklist
isaaclabchangelog fragment.CONTRIBUTORS.md.