Download osmo output skill - #1131
Conversation
🤖 Isaac Lab-Arena Review BotSummaryAdds a Findings🔵 Improvement: SKILL.md:5 — The verify step runs Test CoverageDocumentation-only skill — no code paths to test. Nothing needed. VerdictShip it (one optional nit). |
Greptile SummaryAdds an agent skill for downloading one or more OSMO evaluation outputs into local destination folders.
Confidence Score: 3/5This PR should not merge until user-provided workflow names and destination paths are passed to Bash without being interpreted as shell syntax. The new skill directly inserts user inputs into unquoted assignment, command-argument, and loop-list positions, enabling unintended shell evaluation and incorrect argument splitting. Files Needing Attention: skills/user/download-osmo-evaluation-output/SKILL.md
|
| Filename | Overview |
|---|---|
| skills/user/download-osmo-evaluation-output/SKILL.md | Adds the OSMO download procedure, but its batch template and disk check unsafely interpolate user-provided shell values. |
| .agents/skills/download-osmo-evaluation-output | Adds a correctly targeted relative symlink that exposes the new skill to agents. |
Reviews (1): Last reviewed commit: "Add skill to download osmo output." | Re-trigger Greptile
Summary
Add skill to download the output of an evaluation on OSMO
Detailed description