Skip to content

Download osmo output skill - #1131

Merged
alexmillane merged 1 commit into
mainfrom
alex/skills/download_osmo_data
Aug 25, 2026
Merged

Download osmo output skill#1131
alexmillane merged 1 commit into
mainfrom
alex/skills/download_osmo_data

Conversation

@alexmillane

Copy link
Copy Markdown
Collaborator

Summary

Add skill to download the output of an evaluation on OSMO

Detailed description

  • Saves typing in a long command.

Comment thread skills/user/download-osmo-evaluation-output/SKILL.md
@arena-review-bot

Copy link
Copy Markdown
Contributor

🤖 Isaac Lab-Arena Review Bot

Summary

Adds a download-osmo-evaluation-output user skill (a SKILL.md doc plus the standard .agents/skills/ symlink) that wraps osmo data download for pulling OSMO workflow output locally. It follows the established skill layout and frontmatter conventions, the data vs dataset gotcha and login/resume notes are genuinely useful, and there is no domain/boundary or correctness surface here. Clean, low-risk change.

Findings

🔵 Improvement: SKILL.md:5 — The verify step runs find … | wc -l, but wc is not in allowed-tools, so that pipe will prompt for permission every run. Add Bash(wc *) (or count without the pipe).

Test Coverage

Documentation-only skill — no code paths to test. Nothing needed.

Verdict

Ship it (one optional nit).

@greptile-apps

greptile-apps Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds an agent skill for downloading one or more OSMO evaluation outputs into local destination folders.

  • Registers the skill through the .agents/skills symlink.
  • Documents workflow URI construction, disk checks, downloading, verification, login recovery, resuming, and batch operation.
  • The batch command template interpolates user inputs into unquoted shell syntax.

Confidence Score: 3/5

This PR should not merge until user-provided workflow names and destination paths are passed to Bash without being interpreted as shell syntax.

The new skill directly inserts user inputs into unquoted assignment, command-argument, and loop-list positions, enabling unintended shell evaluation and incorrect argument splitting.

Files Needing Attention: skills/user/download-osmo-evaluation-output/SKILL.md

Security Review

The batch and disk-check templates place user-provided workflow and destination values into unquoted shell positions, allowing shell interpretation rather than preserving those values as inert arguments.

Important Files Changed

Filename Overview
skills/user/download-osmo-evaluation-output/SKILL.md Adds the OSMO download procedure, but its batch template and disk check unsafely interpolate user-provided shell values.
.agents/skills/download-osmo-evaluation-output Adds a correctly targeted relative symlink that exposes the new skill to agents.

Reviews (1): Last reviewed commit: "Add skill to download osmo output." | Re-trigger Greptile

Comment thread skills/user/download-osmo-evaluation-output/SKILL.md
@alexmillane
alexmillane merged commit eae1e4d into main Aug 25, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants