Repository navigation
Fix Linux build: convert rustix errors and satisfy clippy - #1
Merged
Merged
Conversation
The Unix-only model store used ? on rustix calls whose Errno had no conversion into the crate error, so cargo check failed on Linux and CI on main has been red since. Add the conversion, and take the credential open error by reference so the Unix branch of map_open_error passes clippy without an underscore-prefixed binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: CI on
mainhas been red since the last two pushes. On Linux,cargo checkfails incrates/impossible-models/src/store.rsbecause?is applied torustixcalls that returnrustix::io::Errno, which has no conversion into the crate'sError. The Windows job is then cancelled by the matrix, so nothing afterCheckruns on either OS.After: the workspace builds on Linux again, and
cargo clippy --all-targets -D warnings,cargo test --workspaceand the real-binary e2e test all pass on Linux (run locally in arust:1.85.1container).How: add a Unix-only
From<rustix::io::Errno> for Errorthat goes throughstd::io::Error, matching the existingError::Iopath. Once that compiled, clippy flaggedmap_open_errorinimpossible-server-core/src/security.rsfor using an underscore-prefixed binding on Unix, so it now takes&std::io::Errorwith a normal name and allows the unused variable on non-Unix targets only.