Repository navigation
Update rustls and webpki crates for new security advisories - #3
Merged
Merged
Conversation
The Unix-only model store used ? on rustix calls whose Errno had no conversion into the crate error, so cargo check failed on Linux and CI on main has been red since. Add the conversion, and take the credential open error by reference so the Unix branch of map_open_error passes clippy without an underscore-prefixed binding.
cargo deny now fails on RUSTSEC-2026-0346, -0347, -0348, -0349 (rustls), -0382 (rustls-webpki) and -0381/-0383 (webpki-roots, webpki-root-certs). These crates back the TLS client used for model downloads. Bump them to the patched releases and regenerate the third-party notices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the
dependenciesCI job (cargo deny) fails on every branch because of seven new RustSec advisories against the TLS stack that model downloads go through: RUSTSEC-2026-0346, -0347, -0348 and -0349 (rustls0.23.45), -0382 (rustls-webpki0.103.15), and -0381 and -0383 (webpki-roots/webpki-root-certs1.0.9). They include accepting distrusted intermediates and a pre-authentication allocation of up to 1 GiB.After: the lockfile pins
rustls0.23.46,rustls-webpki0.103.16 andwebpki-roots/webpki-root-certs1.0.10, andcargo deny checkreports advisories, bans, licenses and sources as ok.How:
cargo update -pfor those four crates only, so no other dependency moves. All four still declarerust-version = 1.71, so the 1.85.1 toolchain is unaffected.THIRD_PARTY_NOTICES.mdandTHIRD_PARTY_LICENSES.txtwere regenerated withscripts/generate-third-party-notices.ps1, and-Checkpasses. Thevalidatejobs on this branch stay red until the Linux build fix (#1) lands on main.