Repository navigation
wayland: bind only the first wl_seat - #159
Merged
Merged
Conversation
Why: the registry handler rebinds m_waylandState.seat for every wl_seat global, so a client ends up on whichever seat was advertised last. When a compositor exposes extra seats (for example a plugin that adds seats for background automation input), hyprtoolkit apps such as hyprland-dialog attach their pointer and keyboard to that extra seat and never receive the user's clicks or keys, so the ANR dialog cannot be dismissed. How: ignore wl_seat globals once a seat is bound, so the first advertised seat (the compositor's own) is used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 11, 2026
vaxerski
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens @andyhennie's fix from #145, which the autocloser closed as unvouched. This is their diagnosis and commit, verbatim, authorship preserved.
CWaylandPlatform's registry handler rebindsm_waylandState.seatfor everywl_seatglobal and releases the previous one, so when the compositor advertises more than one seat we keep whichever came last, which may not carry the user's input. That is why hyprland-dialog (and Hyprland's ANR dialog, and hyprpolkitagent) stop responding to the real mouse on multi-seat setups. Guard the bind so only the first seat is taken.Single-seat sessions are unaffected: the guard
!m_waylandState.seatis true on the first and only seat, so the bind path is identical. Multi-seat verified by @andyhennie on Hyprland 0.56.2 / hyprland-guiutils 0.2.2 viaLD_LIBRARY_PATH: with the fix the dialog bindswl_seat#4.name("Hyprland")and real clicks reach it. Builds clean here.Fixes #146.