Repository navigation
wayland: bind only the first wl_seat - #145
Closed
andyhennie wants to merge 1 commit into
Closed
andyhennie wants to merge 1 commit into
andyhennie wants to merge 1 commit into
Conversation
Why: the registry handler rebinds m_waylandState.seat for every wl_seat global, so a client ends up on whichever seat was advertised last. When a compositor exposes extra seats (for example a plugin that adds seats for background automation input), hyprtoolkit apps such as hyprland-dialog attach their pointer and keyboard to that extra seat and never receive the user's clicks or keys, so the ANR dialog cannot be dismissed. How: ignore wl_seat globals once a seat is bound, so the first advertised seat (the compositor's own) is used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Hi @andyhennie, Thanks for your contribution! Unfortunately, Hyprland and hypr* no longer To get vouched, please see our contributing guide at wiki.hypr.land/Contributing-and-Debugging This PR has been closed automatically and will not be re-opened. |
Contributor
|
Thanks for the diagnosis and the fix. This was closed by the autocloser because the account isn't vouched, so I reopened it as #159 with your commit and authorship preserved. Credit is yours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CWaylandPlatform's registry handler rebindsm_waylandState.seatfor everywl_seatglobal, releasing the previous one. When a compositor advertises more than one seat, a hyprtoolkit app ends up on whichever seat came last.I hit this with a Hyprland plugin that adds two extra seats for background automation input.
hyprland-dialog(and so Hyprland's "Application Not Responding" dialog) attached its pointer and keyboard to the last of those extra seats. Clicks from the real mouse on the compositor's own seat never reached it, so Terminate/Wait did nothing and the dialog could not be dismissed.WAYLAND_DEBUG=1 hyprland-dialog ...on that session, before:After this change:
Fix
Ignore further
wl_seatglobals once a seat is bound, so the first advertised seat (the compositor's own) is used. No change for single-seat setups.Tested on Hyprland 0.56.2 with hyprland-guiutils 0.2.2, loading this build through
LD_LIBRARY_PATHon the multi-seat session: the dialog now binds the compositor's seat (log above). The change only skips seats after the first, so a single-seat session binds the same seat as before.🤖 Generated with Claude Code