Repository navigation
system/icons: search a theme's dirs across all base dirs - #157
Merged
Merged
Conversation
getThemeDir only kept a base dir that had its own index.theme, and parseTheme added lookup paths only under that base. But a theme's index.theme lives in one base dir while its icon dirs can span all of them (chromium drops PWA icons into ~/.local/share/icons/hicolor/<size>/apps with no index.theme there), so those were never searched. Add each Directories entry under every base dir.
This was referenced Nov 11, 2026
vaxerski
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getThemeDironly keeps a<base>/<theme>dir that has its ownindex.theme, andparseThemethen added lookup paths under that one base only. But a theme'sindex.themelives in one base dir while its icon dirs can be spread across all of them. Chromium drops PWA icons into~/.local/share/icons/hicolor/<size>/appswith noindex.themethere, so they were never searched and those app icons went missing.Add each
Directoriesentry under every base dir, not just the one holding the index.theme.Verified through the public API: an icon under
$XDG_DATA_HOME/icons/hicolor/48x48/apps(noindex.themethere, the theme'sindex.themeunder$XDG_DATA_DIRS) giveslookupIcon()->exists()0 on main and 1 with this. An icon next to theindex.themeresolves on both. Additive, so anything that resolved before still does.Fixes #125. Related: #28 (the XDG_DATA_DIRS discovery it proposed is already on main) and hyprlauncher#132.