You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
icons: theme dirs without index.theme in a base dir are skipped, breaking cross-base-dir merging (all Chromium PWA icons invisible) #125
CSystemIconFactory::getThemeDir() skips a <base>/icons/<theme> dir entirely when it has no index.theme. Per the de-facto freedesktop behavior implemented by GTK and Qt, a theme is defined by an index.theme found in any base dir, and icon lookup then searches that theme's Directories across all base dirs ($XDG_DATA_HOME first, then $XDG_DATA_DIRS).
Chromium-based browsers (Chrome/Brave/Edge) install PWA icons into ~/.local/share/icons/hicolor/<size>/apps/*.png without ever creating ~/.local/share/icons/hicolor/index.theme. On GTK/Qt this works because /usr/share/icons/hicolor/index.theme defines the theme and the lookup merges base dirs. With hyprtoolkit the entire user-local hicolor copy is skipped, so all browser PWA icons are invisible — this affects hyprlauncher and every hyprtoolkit consumer (e.g. hyprland-dialog).
hicolor is also special-cased by the spec as the always-present fallback theme, which makes skipping it even more surprising.
Reproduction
Install any site as a PWA in Chromium/Chrome/Brave
HT_TRACE=1 hyprlauncher logs: CSystemIconFactory: skipping theme dir /home/<user>/.local/share/icons/hicolor (no index.theme)
Workaround
Create ~/.local/share/icons/hicolor/index.theme declaring the size dirs present. Verified on hyprlauncher 0.1.6-7 (Arch): after adding it, the trace shows
and all PWA icons appear (merging works correctly once the file exists — the system hicolor is not shadowed).
Suggested direction
When a same-named theme dir in some base dir lacks index.theme, fall back to the Directories list of the same theme found in another base dir (or special-case hicolor as an always-on fallback), matching GTK/Qt merging behavior.
In at least one of the theme directories there must be a file called index.theme that describes the theme. The first index.theme found while searching the base directories in order is used. This file describes the general attributes of the theme.
It describes the entire theme. What's in ~/.local/share should be treated as an overlay, first look in there, then in system files.
The file in /usr satisfies In at least one of the theme directories. That's hwo every other desktop does it as well.
It describes the entire theme. What's in ~/.local/share should be treated as an overlay, first look in there, then in system files. The file in /usr satisfies In at least one of the theme directories. That's hwo every other desktop does it as well.
Confirmed the cause. getThemeDir only keeps a <base>/<theme> dir when that dir has its own index.theme, and parseTheme then added the theme's Directories under that single base. So when chromium writes its PWA icons into ~/.local/share/icons/hicolor/<size>/apps (no index.theme there), that path never made it into the lookup list and the icons came back empty.
Fix in #157: add each Directories entry under every icon base dir, not just the one holding the index.theme, which is how GTK/Qt resolve it too. Verified by planting an icon under ~/.local/share/icons/hicolor/48x48/apps and logging the lookup paths with and without the change.
Activity
mariuszste commentedon Aug 18, 2026
Also affects icons created by Wine
Workaround
ln -s /usr/share/icons/hicolor/index.theme ~/.local/share/icons/hicolor/index.themevaxerski commentedon Aug 20, 2026
wait, isn't the lack of index.theme... invalid?
mariuszste commentedon Aug 20, 2026
https://specifications.freedesktop.org/icon-theme/latest/#directory_layout
vaxerski commentedon Aug 22, 2026
so where is the index.theme describing hicolor?
YUxiangLuo commentedon Aug 22, 2026
sorry, will close it.
mariuszste commentedon Aug 25, 2026
/usr/share/icons/hicolor/index.theme
It describes the entire theme. What's in
~/.local/shareshould be treated as an overlay, first look in there, then in system files.The file in
/usrsatisfiesIn at least one of the theme directories. That's hwo every other desktop does it as well.please re-open @YUxiangLuo
YUxiangLuo commentedon Aug 25, 2026
ok
UncleJ4ck commentedon Nov 9, 2026
Confirmed the cause.
getThemeDironly keeps a<base>/<theme>dir when that dir has its ownindex.theme, andparseThemethen added the theme'sDirectoriesunder that single base. So when chromium writes its PWA icons into~/.local/share/icons/hicolor/<size>/apps(no index.theme there), that path never made it into the lookup list and the icons came back empty.Fix in #157: add each
Directoriesentry under every icon base dir, not just the one holding the index.theme, which is how GTK/Qt resolve it too. Verified by planting an icon under~/.local/share/icons/hicolor/48x48/appsand logging the lookup paths with and without the change.