Skip to content

system/icons: search a theme's dirs across all base dirs - #151

Closed
UncleJ4ck wants to merge 1 commit into
hyprwm:mainfrom
UncleJ4ck:fix-icon-cross-base-dirs
Closed

UncleJ4ck wants to merge 1 commit into
hyprwm:mainfrom
UncleJ4ck:fix-icon-cross-base-dirs

Conversation

@UncleJ4ck

Copy link
Copy Markdown
Contributor

getThemeDir only keeps a <base>/<theme> dir that has its own index.theme, and parseTheme then added lookup paths under that one base only. But a theme's index.theme lives in one base dir while its icon dirs can be spread across all of them. Chromium drops PWA icons into ~/.local/share/icons/hicolor/<size>/apps with no index.theme there, so they were never searched and those app icons went missing.

Add each Directories entry under every base dir, not just the one holding the index.theme.

Verified: planted an icon at ~/.local/share/icons/hicolor/48x48/apps and logged the lookup paths. With the change that dir is in the search list; reverting to the single-base loop drops it. Additive, so anything that resolved before still does.

Fixes #125. Related: #28 (the XDG_DATA_DIRS discovery it proposed is already on main) and hyprlauncher#132.

getThemeDir only kept a base dir that had its own index.theme, and parseTheme
added lookup paths only under that base. But a theme's index.theme lives in one
base dir while its icon dirs can span all of them (chromium drops PWA icons into
~/.local/share/icons/hicolor/<size>/apps with no index.theme there), so those
were never searched. Add each Directories entry under every base dir.
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Hi @UncleJ4ck,

Thanks for your contribution! Unfortunately, Hyprland and hypr* no longer
accept contributions from unvouched contributors.

To get vouched, please see our contributing guide at wiki.hypr.land/Contributing-and-Debugging

This PR has been closed automatically and will not be re-opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

icons: theme dirs without index.theme in a base dir are skipped, breaking cross-base-dir merging (all Chromium PWA icons invisible)

1 participant