Repository navigation
Conversation
getThemeDir only kept a base dir that had its own index.theme, and parseTheme added lookup paths only under that base. But a theme's index.theme lives in one base dir while its icon dirs can span all of them (chromium drops PWA icons into ~/.local/share/icons/hicolor/<size>/apps with no index.theme there), so those were never searched. Add each Directories entry under every base dir.
|
Hi @UncleJ4ck, Thanks for your contribution! Unfortunately, Hyprland and hypr* no longer To get vouched, please see our contributing guide at wiki.hypr.land/Contributing-and-Debugging This PR has been closed automatically and will not be re-opened. |
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getThemeDironly keeps a<base>/<theme>dir that has its ownindex.theme, andparseThemethen added lookup paths under that one base only. But a theme'sindex.themelives in one base dir while its icon dirs can be spread across all of them. Chromium drops PWA icons into~/.local/share/icons/hicolor/<size>/appswith noindex.themethere, so they were never searched and those app icons went missing.Add each
Directoriesentry under every base dir, not just the one holding the index.theme.Verified: planted an icon at
~/.local/share/icons/hicolor/48x48/appsand logged the lookup paths. With the change that dir is in the search list; reverting to the single-base loop drops it. Additive, so anything that resolved before still does.Fixes #125. Related: #28 (the XDG_DATA_DIRS discovery it proposed is already on main) and hyprlauncher#132.