Repository navigation
Conversation
onKey only forwarded the arrow keys as non-character input, so Home and End (and their keypad variants) were treated as compose and never reached the textbox. Forward them too, with a unit test that they move the cursor to the start and end without changing the text.
|
Hi @UncleJ4ck, Thanks for your contribution! Unfortunately, Hyprland and hypr* no longer To get vouched, please see our contributing guide at wiki.hypr.land/Contributing-and-Debugging This PR has been closed automatically and will not be re-opened. |
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens @Squidroot2's fix from #137 (auto-closed as unvouched), their commit and test, authorship preserved.
onKeyonly forwarded the arrow keys as non-character input, so Home and End (and their keypad variants) fell to the compose path and never reached the textbox. Forward them too. The PR's own unit test covers it: Home/End move the cursor to the start and end without changing the text.Verified here: the test passes with the change and fails without it (reverting just the onKey line makes
homeEndReachTextboxfail on keyPresses).Fixes #138.