Skip to content

core/wayland: pass Home and End through as non-character keys - #150

Closed
UncleJ4ck wants to merge 1 commit into
hyprwm:mainfrom
UncleJ4ck:fix-home-end-keys
Closed

UncleJ4ck wants to merge 1 commit into
hyprwm:mainfrom
UncleJ4ck:fix-home-end-keys

Conversation

@UncleJ4ck

Copy link
Copy Markdown
Contributor

Reopens @Squidroot2's fix from #137 (auto-closed as unvouched), their commit and test, authorship preserved.

onKey only forwarded the arrow keys as non-character input, so Home and End (and their keypad variants) fell to the compose path and never reached the textbox. Forward them too. The PR's own unit test covers it: Home/End move the cursor to the start and end without changing the text.

Verified here: the test passes with the change and fails without it (reverting just the onKey line makes homeEndReachTextbox fail on keyPresses).

Fixes #138.

onKey only forwarded the arrow keys as non-character input, so Home and End
(and their keypad variants) were treated as compose and never reached the
textbox. Forward them too, with a unit test that they move the cursor to the
start and end without changing the text.
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Hi @UncleJ4ck,

Thanks for your contribution! Unfortunately, Hyprland and hypr* no longer
accept contributions from unvouched contributors.

To get vouched, please see our contributing guide at wiki.hypr.land/Contributing-and-Debugging

This PR has been closed automatically and will not be re-opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Home and End keys are not processed correctly

2 participants