Repository navigation
Treat Home and End Keys the same as direction keys - #137
Closed
Squidroot2 wants to merge 3 commits into
Closed
Squidroot2 wants to merge 3 commits into
Squidroot2 wants to merge 3 commits into
Conversation
|
Hi @Squidroot2, Thanks for your contribution! Unfortunately, Hyprland and hypr* no longer To get vouched, please see our contributing guide at wiki.hypr.land/Contributing-and-Debugging This PR has been closed automatically and will not be re-opened. |
Contributor
|
thanks for the fix and the test. reopened as #156 with your commit and authorship preserved since the autocloser got this one. credit's yours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue I was having with hyprlauncher where the Home and End keys were being ignored. This just adds them to the if statement for direction buttons so they return early with the correct event data instead of falling through to code for handling keys associated with a UTF-8 string.
This is my first contribution so forgive me if there is a good reason that the Home and End keys shouldn't be handled like the direction keys. But I can confirm that this did resolve my issue.
Test was generated with an LLM but I did review it and it seemed sensible enough.