Repository navigation
element/text: do not cache preferred size - #122
Merged
Merged
Conversation
Merged
vaxerski
reviewed
Aug 20, 2026
vaxerski
left a comment
Member
There was a problem hiding this comment.
some tests for this would be nice
BlueZeeKing
force-pushed
the
review
branch
3 times, most recently
from
August 22, 2026 22:53
c83afff to
3e60fd2
Compare
BlueZeeKing
marked this pull request as ready for review
August 22, 2026 23:02
BlueZeeKing
force-pushed
the
review
branch
3 times, most recently
from
August 23, 2026 21:40
ca302e4 to
c0e6d76
Compare
Member
|
@codex review please |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0e6d76305
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BlueZeeKing
force-pushed
the
review
branch
2 times, most recently
from
August 24, 2026 14:53
c0e6d76 to
6f53cef
Compare
Contributor
Author
|
I've reviewed this on my own with AI but for each fix I've written the code and tests |
Currently, the preferred size of text depends on the previous size, which leads to oscilations and weird edge cases where text may not grow correctly. This also removes hacks around text using the max size of the parent not the actual size it was given. This does not impact performance because the pango layout is cached.
vaxerski
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the preferred size of text depends on the previous size, which leads to oscilations and weird edge cases where text may not grow correctly. This also removes hacks around text using the max size of the parent not the actual size it was given. This does not impact performance because the pango layout is cached.
This does the same thing as #121