Repository navigation
A bunch of layout fixes - #123
Merged
Merged
Conversation
BlueZeeKing
force-pushed
the
layout-fix
branch
from
August 24, 2026 21:01
3a2e033 to
826dacb
Compare
Member
|
is this ready or a draft |
Contributor
Author
There's still a couple more things I want to fix up and review, but should be ready by the end of the week |
BlueZeeKing
force-pushed
the
layout-fix
branch
5 times, most recently
from
August 30, 2026 04:58
10caef1 to
cd43366
Compare
Contributor
Author
Contributor
Author
|
@vaxerski this PR is ready except for deciding what to do about percent children in elements. (See above message) |
Previously the child got it's preferred size even if it was bigger than the parent. This should not happen, but it is possible with row or column layouts. This could be fixed in every case where an element misbehaves, but it is easiest to fix here.
Member
|
should be configurable for the slider. Maybe hide it by default. As for percent, you can break old layouts as long as it doesnt make shit completely explode |
BlueZeeKing
force-pushed
the
layout-fix
branch
2 times, most recently
from
September 13, 2026 16:19
1150acd to
90497ce
Compare
BlueZeeKing
marked this pull request as ready for review
September 13, 2026 16:21
This reports the parent size to the child of a layout, instead of directly reporting the layouts size. This is only reported if the size of the layout is automatic. This allows the layout to grow to the full size of the parent instead of staying in place. In order to prevent percent based elements from growing to the full size of the parent, a grow flag is added that stops percentage based sizes from applying.
BlueZeeKing
force-pushed
the
layout-fix
branch
from
September 13, 2026 16:36
90497ce to
29cfbbf
Compare
This does not change the way it looks
This was referenced Sep 13, 2026
Contributor
Author
|
I tested hyprpaper, hyprlauncher, hyprsysteminfo, hyprshutdown, hyprpwcenter, hyprland-guiutils, hyprpolkitagent, and the hyprland overview and only hyprpwcenter and hyprshutdown had minor layout issues, but both were still usable. I made draft prs for both |
vaxerski
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This has not been tested without #122This passes the parent sized down to children when a given element is auto sized. This allows elements with automatic sizes to grow if necessary.
This adds a specific grow flag to
preferredSizewhich controls whether percents are calculated or not. This is necessary because when an element is auto sized we don't want children that are percent sized to grow to fill the entire parent.