Repository navigation
fix(ci): CI context contract follows the secret-scan → scan rename - #66
Conversation
#62 (D243) renamed the secret-scanner caller job from `secret-scan` to `scan`, so it publishes `scan / gitleaks`, `scan / rust-secrets` and `scan / shell-secrets`. .machine_readable/CI-CONTEXTS.a2ml still named the old caller, and `Required contexts are producible` has been red on main since (CONTRACT BROKEN: 'no longer defines caller job secret-scan'). The contract and the docs table now name the caller as it is. Reproduced: tools/check-ci-contexts.sh . --no-network → CONTRACT BROKEN, rc=1. After: contract intact, rc=0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VTeVWDEJgdYKsUNr4uhnXX
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Required contexts are produciblehas been red onmainsince #62 (2026-10-01). That PR (D243) renamed the secret-scanner caller job fromsecret-scantoscan, but.machine_readable/CI-CONTEXTS.a2mlstill declares the old caller:This changes the contract's
caller-job-idandpublished-contexts, plus the matching row indocs/CI-CONTEXTS.adoc, toscan/scan / gitleaks|rust-secrets|shell-secrets. Three lines in two files. No workflow is changed.Type of change
How has this been verified?
bash tools/check-ci-contexts.sh . --no-networkonmain's tree →CONTRACT BROKEN, rc=1 (reproduced)check-ci-contexts: contract intact, rc=0Notes for reviewers
The same commit is ported into #65 (Lean v4.35.0 move), which hits this pre-existing red. Once this merges, the port is a no-op there.
Generated by Claude Code