Skip to content

test(baseline): use [[ ]] in the invalid_actions_lock ledger guard - #1305

Merged
hyperpolymath merged 3 commits into
mainfrom
claude/kind-curie-w54eub
Oct 19, 2026
Merged

hyperpolymath merged 3 commits into
mainfrom
claude/kind-curie-w54eub

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Follow-up to #1239. SonarCloud's quality gate passed on #1239 but reported 1 new issue. The session that wrote #1239 could not open the finding, because its proxy blocks sonarcloud.io.

The only conditional #1239 added is if [ "$got" = "0" ] in scripts/tests/apply-baseline-test.sh, the guard that keeps an invalid_actions_lock ack out of the shipped baseline. #1291 answered the same Sonar rule elsewhere in this repo with Bash [[ ... ]], so this PR does the same to this one line:

-  if [ "$got" = "0" ]; then
+  if [[ "$got" == "0" ]]; then

The rest of the file is unchanged.

Testing

Check Result
bash scripts/tests/apply-baseline-test.sh 52 passed, 0 failed
Mutation: an invalid_actions_lock ack restored to a copy of .hypatia-baseline.json 2 FAIL, exit 1. The guard still fails on its target.
.githooks/pre-commit and commit-msg passed, including gitleaks, SPDX and validate-actions-lock

Unconfirmed: I could not read the Sonar finding itself, so this PR's Sonar run is the confirmation. If Sonar still reports a new issue here, it was something else and I'll follow up.


Generated by Claude Code

SonarCloud reported one new issue on #1239. The proxy in the session
that wrote #1239 could not reach sonarcloud.io, so the finding itself
was never read. The only conditional #1239 added is
`if [ "$got" = "0" ]` in scripts/tests/apply-baseline-test.sh, and
this repo already answers that Sonar rule with Bash `[[ ... ]]` (#1291).

Behaviour is unchanged. The suite passes 52/52. With an
invalid_actions_lock ack put back into a copy of the baseline, the
guard still fails (2 FAIL, exit 1).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TbbnKqskQA5mj5gfMniPzi
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

DEED–K9 green

🟢 conformant · commit a5e826eeafd1 · run 39293900481

Category Status Pass Fail Indeterminate N/A Since previous revision
DEED syntax 🟢 conformant 4 0 0 0 ↔ unchanged
K9 contract typecheck 🟢 conformant 1 0 0 0 ↔ unchanged
K9 validator self-test 🟢 conformant 34 0 0 0 ↔ unchanged
K9 positive/negative controls 🟢 conformant 27 0 0 0 ↔ unchanged
K9 live corpus (L0–L2) 🟢 conformant 12 0 0 2 ↔ unchanged
K9 live corpus (L0–L2): 2 finding(s) / scope notes
  • 2-protocols/k9-coordination/examples/minimal.k9 — not_applicable: Routed to another dialect; not validated as a K9 contract.
  • coordination.k9 — not_applicable: Routed to another dialect; not validated as a K9 contract.

Scope: DEED syntax and K9 contracts L0–L2. L3 signature verification and routed coordination dialects are not certified. Green is limited to this scope. Orange is missing evidence; grey is an explicit scope exclusion. Logs and report.json are in the dated conformance-evidence artifact on the linked run.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 11915707-1148-484c-8f36-90d51809fd3f
📥 Commits

Reviewing files that changed from the base of the PR and between c314ddf and a5e826e.

📒 Files selected for processing: 1
  • scripts/tests/apply-baseline-test.sh
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

scan / Hypatia Neurosymbolic Analysis is red here, but the failure is not this PR's. governance / Validate Hypatia Baseline will most likely go red for the same reason.

No re-run: the failure is deterministic and already reproduces on main. I'm keeping this PR watched until the upstream fix lands.


Generated by Claude Code

@hyperpolymath
hyperpolymath marked this pull request as ready for review October 19, 2026 16:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T17:29:43.899698Z a5e826e New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hyperpolymath
hyperpolymath enabled auto-merge (squash) October 19, 2026 17:24
@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 9edd8c2 into main Oct 19, 2026
50 of 52 checks passed
@hyperpolymath
hyperpolymath deleted the claude/kind-curie-w54eub branch October 19, 2026 17:25
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Add Carrot credits or activate Agent usage billing to use Autofix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants