Repository navigation
feat(fork-governance): carry the gitbot-fleet enrolment manifest and report-back producer - #263
Merged
Merged
Conversation
…report-back producer Every repository instantiated from this template inherits a Hypatia verdict grid whose fleet rows can only read "enrolled, but no report-back was received", because nothing produced the envelopes. The producer now exists (hyperpolymath/gitbot-fleet#626); the template carries its adoption so new repositories start wired. * .gitbot-fleet/enrolment.json: template defaults enrol rhodibot, finishingbot and glambot (true of every estate repository) and mark the rest `enrolled: false` with a reason saying when to flip them. .gitbot-fleet/report-backs/ holds only a README: envelopes are per-run evidence and are never committed. * fork-governance.yml: an inline `fleet` job (check out gitbot-fleet at FLEET_REF, build only the enrolled adapters, run the driver, upload the `fleet-report-backs` artifact). Inline rather than `uses:` because a repository made from this template may live under an owner whose Actions policy refuses a cross-owner reusable at plan time. The verdict job downloads the artifact and lists each member's status in the step summary, so the evidence is visible here even before the repository adopts the standards Hypatia reusable that renders it into the grid. * actions.lock: entries and dependency records for the new steps; scripts/check-lock-sync.sh passes. The fleet job's result is reported, not gated: the verdict fails only on DEED or K9, as before. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDjqj5DHRRCrDiGeTmq
Contributor
|
Caution Review failedThe pull request is closed. Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…che; repin gitbot-fleet Drops dtolnay/rust-toolchain and swatinem/rust-cache (and their lockfile records) from the fleet job: the runner image carries stable Rust and the cache is actions/cache keyed on the fleet commit's lockfiles, so the job uses only GitHub-owned, SHA-pinned actions. FLEET_REF moves to 4c9ea43d, which fixes an ARG_MAX failure in the driver on large finding lists. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDjqj5DHRRCrDiGeTmq
|
hyperpolymath
marked this pull request as ready for review
October 27, 2026 05:15
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merged
8 of 12 tasks
hyperpolymath
pushed a commit
that referenced
this pull request
Oct 27, 2026
…rectory estate-rules' repo_map_determinism_test fails when the committed map lags the tree; .gitbot-fleet/ (added in #263) was not yet in it. Regenerated with scripts/gen-repo-map.sh, as 'just repo-map' does. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDjqj5DHRRCrDiGeTmq
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f041159088
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,14 @@ | |||
| { | |||
There was a problem hiding this comment.
Adding .gitbot-fleet/ without registering it in .machine_readable/root-allow.txt makes every pull request fail the Estate Rules workflow: running bash scripts/check-root-shape.sh . on this commit reports this directory as an unallowlisted root entry. After adding the allowlist entry, the subsequent repository-map freshness check in .github/workflows/estate-rules.yml also detects that docs/architecture/REPOSITORY-MAP.adoc lacks the new directory, so add the justified allowlist entry and regenerate the map.
Useful? React with 👍 / 👎.
hyperpolymath
added a commit
that referenced
this pull request
Oct 27, 2026
…the enrolment manifest (#264) ## Summary Follow-up to [#263](#263), which merged before its first CI run finished. Two checks were failing on it and are now red on `main`: - **estate-rules**: `scripts/check-root-shape.sh` rejects `.gitbot-fleet/` because it was not on `.machine_readable/root-allow.txt`. - **Proven 3-outcome test & bench suite**: the `root_shape` and `ijson_jcs` bench workloads report "checksum is false" for the same two facts (the new root entry, and an enrolment manifest that was pretty-printed rather than I-JSON/JCS). ## Changes - `.machine_readable/root-allow.txt`: `.gitbot-fleet/` is a required root entry, with the reason (manifest + report-backs directory the Hypatia verdict grid reads at this path and no other). - `.gitbot-fleet/enrolment.json`: key-sorted compact JSON with one final LF, per `3-practice/JSON-POLICY.adoc`. ## RSR Quality Checklist ### Required - [x] Tests pass: `scripts/check-root-shape.sh .` (45 entries), `scripts/check-ijson-jcs.sh --enforce .` (13/13 canonical), `scripts/check-lock-sync.sh` - [x] Code is formatted - [x] Linter is clean - [x] No banned language patterns - [x] No `unsafe` blocks without `// SAFETY:` comments - [x] No banned functions - [x] SPDX license headers present on all new/modified source files (no source files changed) - [x] No secrets, credentials, or `.env` files included ### As Applicable - [ ] Repo deed updated — not needed - [ ] `docs/status/ROADMAP.adoc` — not changed - [ ] Documentation — not changed - [ ] `CHANGELOG` — regenerated from commits --- _Generated by [Claude Code](https://claude.ai/code/session_01J4QvDjqj5DHRRCrDiGeTmq)_ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary by CodeRabbit * **Documentation** * Updated the repository map to identify the fleet enrolment manifest and describe its role in supporting per-run report-backs and the verdict grid. * The manifest’s enrolment statuses, titles, and reasons are unchanged; its entries were reordered without changing their meaning. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every repository instantiated from this template inherits a Hypatia verdict grid whose gitbot-fleet rows can only read 🟠 "enrolled, but no report-back was received", because nothing in the estate produced the envelopes the grid reads. The producer now exists in hyperpolymath/gitbot-fleet#626; this PR makes the template carry its adoption so new repositories start wired. Guide: standards
3-practice/fork-governance/ADOPTION.adoc§8 (in the companion standards change).Changes
.gitbot-fleet/enrolment.json: template defaults enrol rhodibot, finishingbot and glambot (true of every estate repository); every other member isenrolled: falsewith a reason that says when to flip it..gitbot-fleet/report-backs/README.mdexplains that the directory stays empty in git: envelopes are per-run evidence, never committed..github/workflows/fork-governance.yml: an inlinefleetjob (checkouthyperpolymath/gitbot-fleetatFLEET_REF, build only the enrolled adapters with rust-cache, runscripts/fleet-report-back.sh, upload thefleet-report-backsartifact). Inline rather thanuses:because a repository made from this template may live under an owner whose Actions policy refuses a cross-owner reusable at plan time (zero jobs, no error line). Theverdictjob downloads the artifact and lists each member's status in the step summary, so the evidence is visible here before the repository adopts the standards Hypatia reusable that renders it into the grid. The fleet result is reported, not gated..github/workflows/actions.lock: entries for the new steps plus dependency records fordtolnay/rust-toolchainandswatinem/rust-cache;scripts/check-lock-sync.shpasses (transitively closed).RSR Quality Checklist
Required
scripts/check-lock-sync.sh; the workflow itself first runs on this PR)unsafeblocks without// SAFETY:comments.envfiles includedAs Applicable
(status)/(maturity)updated — not changed; a(fleet :enrolment … :report-backs …)clause like metamanifold-webui's deed carries is left for a follow-up pending a check that the deed grammar admits itdocs/status/ROADMAP.adocupdated — not changed.gitbot-fleet/report-backs/README.md, workflow header)TOPOLOGY.md— unchangedCHANGELOG— regenerated from commitsDepends on gitbot-fleet#626 for
FLEET_REFto exist on a branch; bump the pin to the merge commit once it lands.Generated by Claude Code