Repository navigation
fix(fork-governance): allow .gitbot-fleet/ at the root; canonicalise the enrolment manifest - #264
Conversation
…the enrolment manifest #263 merged before its first CI run finished, and two checks were failing on it: estate-rules (root shape: .gitbot-fleet/ was not on .machine_readable/root-allow.txt) and the proven bench suite, whose root_shape and ijson_jcs workloads broke on the same two facts (the manifest was pretty-printed, not I-JSON/JCS). Both are fixed here: .gitbot-fleet/ is a required root entry with its reason, and enrolment.json is key-sorted compact JSON with one final LF. Verified: scripts/check-root-shape.sh . passes (45 entries), scripts/check-ijson-jcs.sh --enforce . reports 13/13 canonical, scripts/check-lock-sync.sh unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDjqj5DHRRCrDiGeTmq
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 53 minutes. View limit details
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Manifest and repository registration .gitbot-fleet/enrolment.json, .machine_readable/root-allow.txt, docs/architecture/REPOSITORY-MAP.adoc |
The enrolment JSON is compacted and its reporter entries are reordered; its schema and reporter values remain unchanged. The allowlist permits .gitbot-fleet/, and the repository map describes its manifest, report-backs, and Hypatia verdict-grid reader. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Possibly related issues
- hyperpolymath/ijson-jcs#7: This change applies the canonical file profile to the enrolment manifest, but does not implement the issue’s standards-alignment pipeline.
Possibly related PRs
- hyperpolymath/rsr-template-repo#253: That PR adds canonical JSON enforcement and updates root-shape and repository-map rules; this change applies related formatting and registration updates to
.gitbot-fleet/. - hyperpolymath/rsr-template-repo#252: That PR defines I-JSON/JCS routing; this change formats the enrolment manifest under the related canonical JSON policy.
Suggested reviewers: {{owner}}
Merge Risk: 
74458
-
The manifest and repository registration changes are ready to merge based on the supplied evidence.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly identifies both main changes: allowing the .gitbot-fleet/ root directory and canonicalising its enrolment manifest. Description check The description covers the purpose, key changes, validation commands, and checklist. It omits dedicated Testing and Screenshots sections, and it incorrectly states that documentation was not changed e… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description covers the purpose, key changes, validation commands, and checklist. It omits dedicated Testing and Screenshots sections, and it incorrectly states that documentation was not changed even though REPOSITORY-MAP.adoc was updated.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
…rectory estate-rules' repo_map_determinism_test fails when the committed map lags the tree; .gitbot-fleet/ (added in #263) was not yet in it. Regenerated with scripts/gen-repo-map.sh, as 'just repo-map' does. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDjqj5DHRRCrDiGeTmq
|
Add Carrot credits or activate Agent usage billing to use Autofix |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…; repin gitbot-fleet Walk-based adapters (glambot, finishing-bot) were scanning the gitbot-fleet checkout under .fleet-src as if it were this repository. The checkout is moved to RUNNER_TEMP before any adapter runs and the cache key hashes the fleet lockfiles before the move. FLEET_REF moves to e85b71bf, which carries the same fix in the reusable plus rhodibot's found-path reporting. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J4QvDjqj5DHRRCrDiGeTmq
|
Summary
Follow-up to #263, which merged before its first CI run finished. Two checks were failing on it and are now red on
main:scripts/check-root-shape.shrejects.gitbot-fleet/because it was not on.machine_readable/root-allow.txt.root_shapeandijson_jcsbench workloads report "checksum is false" for the same two facts (the new root entry, and an enrolment manifest that was pretty-printed rather than I-JSON/JCS).Changes
.machine_readable/root-allow.txt:.gitbot-fleet/is a required root entry, with the reason (manifest + report-backs directory the Hypatia verdict grid reads at this path and no other)..gitbot-fleet/enrolment.json: key-sorted compact JSON with one final LF, per3-practice/JSON-POLICY.adoc.RSR Quality Checklist
Required
scripts/check-root-shape.sh .(45 entries),scripts/check-ijson-jcs.sh --enforce .(13/13 canonical),scripts/check-lock-sync.shunsafeblocks without// SAFETY:comments.envfiles includedAs Applicable
docs/status/ROADMAP.adoc— not changedCHANGELOG— regenerated from commitsGenerated by Claude Code
Summary by CodeRabbit