Skip to content

chore(ci): final repin of estate-audit reusable (cicd-suite#12 follow-up) — transitive graph fully pinned - #124

Merged
hyperpolymath merged 1 commit into
mainfrom
repin-estate-audit-final
Sep 17, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
repin-estate-audit-final

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Third and final repin — completes the chain that ends the estate-audit startup_failure era (ongoing since Sep 13, commit f28a32e).

Why #116 wasn't the end: the caller pin 7689b04 had the workflow-level refs pinned (cicd-suite#11), but the startup rejection was transitive — GitHub validates the full action graph at run creation once refs are remote-style, and manifest-check's composite internals still carried two @main cross-repo refs (deed-ecosystem/validate-action, k9-ecosystem/validate-action). With sha_pinning_required: true on both repos, the whole run was rejected before a single job existed — the 0-job, 0-annotation signature. cicd-suite#12 (merged 20:38 UTC) pinned those two; this bump makes the caller reference a fully pinned graph (53fd9e0).

Built-in witness: opening this PR fires the reusable via on: pull_request. If the check creates a real job, the audit's 26 gates report genuine signal for the first time in five days — whatever they then say (some step-level failures are plausible; the suite has 22 in its history while it stabilises) is information replacing mystery.

One line changed; YAML re-parsed; single permissions: block intact (#110); pin comment records the full provenance (3/3).

Third and last repin. #116 pointed the caller at 7689b04 (workflow-level
refs pinned), but the startup rejection was transitive: manifest-check's
composite internals still carried two @main cross-repo refs, which
sha_pinning_required rejects at run creation — zero jobs, zero
annotations, since f28a32e on Sep 13. cicd-suite#12 pinned those two;
this bump makes the caller reference a fully pinned graph.

Opening this PR is the witness: on:pull_request fires the reusable, and
if a real job finally spawns, the 0-job era is over and the audit's 26
gates report genuine signal for the first time in five days.
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 667f5abe-39f7-4660-900a-8d7e0c19d2cb

📥 Commits

Reviewing files that changed from the base of the PR and between dbae863 and 5aaa979.

📒 Files selected for processing (1)
  • .github/workflows/main-estate-audit.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit a54cbf5 into main Sep 17, 2026
60 of 61 checks passed
@hyperpolymath
hyperpolymath deleted the repin-estate-audit-final branch September 17, 2026 21:01
@hyperpolymath

Copy link
Copy Markdown
Owner Author

Superseded — root cause of the 0-job estate-audit era found: GitHub's native Actions lockfile enforcement (gh actions-lock, .github/workflows/actions.lock). The callee content at 53fd9e0 is itself non-compliant (remote-form self-refs + SHA-form checkout are not lockfile keys), so repinning the caller to it cannot help — every witness died 0-job at run creation. cicd-suite#14 restores the compliant callee ($/actions/* refs, checkout@v7.0.1, deed/k9 internals at @main matching the lock keys — verbatim annotation proof: "lockfile missing pin for hyperpolymath/deed-ecosystem@f9d999b…"). After #14 merges, the caller fix follows: repin to the post-merge head, ideally moving the caller onto @main + an rsr lockfile entry (hyperpolymath/cicd-suite@main) so gh actions-lock --relock replaces the manual repin treadmill permanently. Closing to prevent pinning main to non-compliant callee content.

hyperpolymath added a commit that referenced this pull request Sep 17, 2026
…tool-normalized lock order

cicd-suite#14 merged (main 98f405a): the callee is native-lockfile-
compliant ($/actions/* refs, checkout@v7.0.1 lock key, deed/k9@main
internals) and its own main push runs are green (audit 35276576603,
self-test 35276576597). The caller's @53fd9e0 pin points at PRE-fix
content, so every rsr estate-audit run since #124 merged has died
0-job on the callee side.

Switch the caller to @main: cross-repo reusable-workflow calls are not
lockfile-pinnable deps (gh actions-lock scoped run on this file:
'All 1 workflow valid', no entry added) — enforcement lives in the
callee's own onboarded lockfile, and cicd-suite main is gated green
on every push. This ends the manual repin treadmill (#110/#116/#124).

Also includes gh actions-lock's normalization of the deed-validate
lockfile key position (sorted order) from #125.
hyperpolymath added a commit that referenced this pull request Sep 17, 2026
…udit caller onto compliant cicd-suite@main (#126)

Two repairs in one, both witnessed on this PR:

**1. dogfood-gate hotfix (commit 1).** #125 was squash-merged at head
`2484338` — seconds before the follow-up fix (`7b04399`) reached the PR.
Main therefore carries a dangling `needs: [a2ml-validate, …]` (the job
was renamed to `deed-validate`) → invalid job graph → main's
dogfood-gate push run
[`35276602266`](https://github.com/hyperpolymath/rsr-template-repo/actions/runs/35276602266)
died **0-job**. This cherry-picks the fix: `needs: [deed-validate, …]` +
scorecard DEED naming (`DEED_STATUS`, presence check scans `.a2ml`
**and** `.deed`).

**2. estate-audit caller → `@main` (commit 2).** cicd-suite#14 merged
(main `98f405a`): the callee is native-lockfile-compliant and **green on
its own main** (audit run
[35276576603](https://github.com/hyperpolymath/cicd-suite/actions/runs/35276576603)
— all 26 gates; self-test
[35276576597](https://github.com/hyperpolymath/cicd-suite/actions/runs/35276576597)).
The caller's `@53fd9e0` pin targets PRE-fix content → every rsr
estate-audit run since #124 died 0-job callee-side. Cross-repo
reusable-workflow calls are not lockfile-pinnable (`gh actions-lock`
scoped run: *"All 1 workflow valid"*, no entry added — enforcement lives
in the callee's own onboarded lockfile, and cicd-suite main is gated
green on every push), so `@main` is both compliant and **the end of the
manual repin treadmill** (#110 → #116 → #124 → done). Lock diff = the
tool normalizing #125's key position into sorted order.

**Witnesses on this PR:** caller run must finally spawn jobs cross-repo;
dogfood-gate must spawn jobs and go green; governance's *Actions
lockfile verify* must stay green.

---------

Co-authored-by: hyperpolymath <hyperpolymath@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant