Repository navigation
fix(analysis): refuse deferred ILR bases and fix 4-sample test gate - #63
Merged
Merged
Conversation
- Refuse deferred ILR bases (phylogenetic, sequential_binary_partition, balance_dendrogram) at construction and in prepare_analysis_table. - Relabel ILR rows to balance_1..n-1 and record basis/taxa diagnostics in checks["ilr"]. - Prevent taxon labels from being restored onto balance rows during healing. - Update prepare_analysis_table test fixture in test/unit/test_scaling.jl to 4 samples to satisfy min_samples_per_group requirement. - Add owner review document (docs/owner-review-2026-09-25.md). Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
arena-ai-coding-agent
Bot
requested a review
from hyperpolymath
as a code owner
September 25, 2026 21:27
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyperpolymath
approved these changes
Sep 25, 2026
hyperpolymath
added a commit
that referenced
this pull request
Sep 25, 2026
## Why Julia tests on `main` have been red since #60, and the reason was never visible: the job log is served from a blob host that some environments cannot reach, and the one annotation the step posted (the last 6000 bytes of output) was truncated by the checks API at 4096 bytes — which cut it off exactly before the failing testset. For `e26d6f2` (#63) all it shows is that `Scaling — TSS, CSS, RSS/TMM and size factors (issue #16)` has a failure. ## What The "Run tests" step, on failure only, now posts: - one `::error` annotation per failing assertion (the Test.jl block starting at `Test Failed at` / `Error During Test at`, up to 60 lines / 3500 bytes, max 8), and - one summary annotation holding only the `Test Summary` rows whose Fail or Error column is non-empty (found by the header's column positions), plus the `ERROR:` line. If no failure block is found (e.g. a load error), the old tail annotation is posted as a fallback. The test command and its exit status are unchanged. ## Verified - YAML re-parses; spdx/format/blob-hygiene gates clean. - The extraction shell was run against a synthetic Test.jl log (one `Test Failed`, one `Error During Test` with `Got exception outside of a @test`, nested summary) and produced exactly two failure annotations and a summary with only the failing rows. ## Not claimed This does **not** fix the red test. It makes the failure readable so the next PR can fix it rather than guess. This PR's own CI run should fail the same way as `main` and name the assertion. Co-authored-by: hyperpolymath <6759885+hyperpolymath@users.noreply.github.com>
hyperpolymath
added a commit
that referenced
this pull request
Oct 19, 2026
…hreshold Compute the best reported weight in the existing query list, retain absent/invalid weights as missing throughout the viewer, and save a threshold with view settings. Avoid assigning a best location or weighted counts when candidate weights are incomplete. Frontend-only reduction requested on upstream #63. bun 1.3.10: 46 tests, TypeScript and production build passed.
hyperpolymath
added a commit
that referenced
this pull request
Oct 22, 2026
…hreshold Compute the best reported weight in the existing query list, retain absent/invalid weights as missing throughout the viewer, and save a threshold with view settings. Avoid assigning a best location or weighted counts when candidate weights are incomplete. Frontend-only reduction requested on upstream #63. bun 1.3.10: 46 tests, TypeScript and production build passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Refusal of Deferred ILR Bases:
AnalysisConfig.DEFERRED_ILR_BASISdefines the deferred bases ("phylogenetic","sequential_binary_partition","balance_dendrogram").NormalizationConfigconstruction and inprepare_analysis_tableinstead of warn-and-substitute.context_help("normalization.ilr_basis")rewritten to document that only the default Helmert basis is implemented and others are deferred (Issue feat(analysis): ILR basis — phylogenetic ILR (PhILR), sequential binary partition (SBP), balance dendrogram #20).Balance Row Labelling & Integrity:
balance_1..balance_n-1.diagnostics.checks["ilr"].CI Test Suite Fix:
prepare_analysis_table keeps counts and hands over the offsettest intest/unit/test_scaling.jlto use a 4-sample fixture (table_4), satisfying themin_samples_per_group=2requirement (>= 2 * 2 = 4samples).rcopy(reval(...)).Documentation & Outreach:
docs/owner-review-2026-09-25.md(with CC-BY-SA-4.0 SPDX header) and CHANGELOG entry.