Skip to content

fix(server): isolate wildcard IP origins and reject overflowing ports - #180

Merged
hyperpolymath merged 5 commits into
mainfrom
work/wildcard-ip-origin
Oct 17, 2026
Merged

hyperpolymath merged 5 commits into
mainfrom
work/wildcard-ip-origin

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Two incremental commits recover the wildcard-bind origin change and then replace throwing port parsing with tryparse. A regression test covers a 100-digit request port. Existing tests cover IP matches, mismatched origins, DNS-rebinding-shaped hostnames and environment isolation.

Validation: whitespace checks pass. Julia and the server tests have not run in this environment. Keep draft until native tests and CI pass; the address regex still needs validation against malformed IPv4/IPv6 literals. No dependency changes or broad documentation rewrite.

Recovered from b672663 after #178; all original work remains on archive/pre-sync-2026-10-17.

Recover b672663 with the origin tests, excluding unrelated documentation.
Use tryparse for request-controlled port text and add a regression test.
Native Julia test execution remains pending.
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 88d5ddc7-72f6-42b0-bad0-bb9f21492545
📥 Commits

Reviewing files that changed from the base of the PR and between abf6f0d and f7b2367.

📒 Files selected for processing: 2
  • src/server/server.jl
  • test/unit/test_server_security.jl

Autofix is active · Waiting for CI/review

Waiting for complete CI and CodeRabbit review evidence.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-17T19:28:51.488896Z f7b2367 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hyperpolymath
hyperpolymath enabled auto-merge (squash) October 17, 2026 10:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 72d188e636

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/server/server.jl Outdated
@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Autofix was enabled. Check current status in the Coding task.

@hyperpolymath
hyperpolymath enabled auto-merge (squash) October 17, 2026 14:39
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@hyperpolymath
hyperpolymath merged commit a843a83 into main Oct 17, 2026
4 checks passed
@hyperpolymath
hyperpolymath deleted the work/wildcard-ip-origin branch October 17, 2026 19:29
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant